feat(containers): PR #10 — onboard CBACT04C batch container (INTCALC) - #181
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
PR #10 / Wave 3: adds only the two per-program config files for CBACT04C using the manifest-driven container pattern (PR #3) - no Dockerfile/pipeline edits. ddmap mirrors INTCALC.jcl (TCATBALF/XREFFILE/ACCTFILE/DISCGRP/TRANSACT -> AWS.M2.CARDDEMO.*). programs manifest uses RUN_MODE=module (cobc -m + cobcrun) so its PROCEDURE DIVISION USING receives PROGRAM_PARM=2022071800 like the JCL PARM=, with no COBOL logic change. Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 3 / PR #10 — first per-program rollout on the manifest-driven container pattern (PR #3). Onboards
CBACT04C(job INTCALC, interest calculator) by adding only two config files — no Dockerfile, CI, or CD edits:Why
RUN_MODE=module(the interesting part):CBACT04ChasPROCEDURE DIVISION USING EXTERNAL-PARMS, which GnuCOBOL rejects for acobc -xexecutable (executable program requested but PROCEDURE/ENTRY has USING clause). The pattern'smodulemode compiles it withcobc -mand runs it viacobcrun CBACT04C 2022071800, so the mainframe JCLPARM='2022071800'flows into the USING item without any source change. DD map mirrorsapp/jcl/INTCALC.jcl(TCATBALF/XREFFILE/ACCTFILE/DISCGRP/TRANSACT), names preserved.Verified locally
docker build --build-arg PROGRAM=CBACT04C→cobc -m -std=ibm -fixed -ftab-width=1compiles the module clean; image builds.Links
docs/modernization/CURRENT_STATE_ANALYSIS.md§4.2 (INTCALC step)docs/modernization/MIGRATION_PLAYBOOK.md. Depends on PR Add comprehensive CardDemo modernization documentation #3.Link to Devin session: https://app.devin.ai/sessions/c0f261ce337a4aee965332f1754d037a
Requested by: @vibhaseshadri-cognition
Devin Review