bug: bump Docker base image to node:22.23.2-trixie (zlib CVE-2023-45853) - #258
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snyk Container finding
SNYK-DEBIAN11-ZLIB-6008961(CVE-2023-45853, CWE-190, CVSS 9.8): thenode:18.13.0base image is Debian 11 withzlib1g 1:1.2.11.dfsg-2+deb11u2, which has no fix in bullseye.Why trixie and not the tags sibling PRs used:
*-bookworm, used by bug: fix SNYK-DEBIAN11-CURL-3320493 (CVE-2023-23914) by moving base image to Debian 12 #118/bug: fix SNYK-DEBIAN11-AOM-1298721 (CVE-2021-30474) by moving the Docker base image to node:18.20.8-bookworm #120/bug: fix SNYK-DEBIAN11-AOM-1290331 (CVE-2021-30473) by moving the Docker base image to node:18.20.8-bookworm #147-bug: fix SNYK-DEBIAN11-AOM-7197980 (CVE-2024-5171) by moving base image to node:18.20.8-bookworm #150) still shipszlib1g 1:1.2.13.dfsg-1, which Snyk flags for the same CVE underSNYK-DEBIAN12-ZLIB-6008963("no fixed version"), so a bookworm bump would not close this finding. Debian 13 shipszlib1g 1:1.3.dfsg+really1.3.1-1, where the MiniZip overflow is fixed.22.23.2-trixieis the current LTS line with a pinned patch version.node:18.20.5-alpine3.19was declined:routes/index.jsshells out to ImageMagickidentify, which the alpine images don't include (the trixie image does,imagemagick 8:7.1.1.43+dfsg1-1+deb13u11).npm startkeepsNODE_OPTIONS=--openssl-legacy-provider, which Node 22 still accepts. Debian 13 also carries the fixed curl/expat/aom packages targeted by the sibling base-image PRs, so this change supersedes them if merged first.Not verified locally: the image build (
npm update/npm installon Node 22) — the sandbox has no Docker daemon or npm registry access.This PR was written by Devin.
Devin-Org: engineering