fix: [npm] Upgrade adm-zip from 0.4.7 to 0.5.18 to resolve CVE-2018-1002204 - #266
Open
hannahhuh-cog wants to merge 1 commit into
Open
hannahhuh-cog wants to merge 1 commit into
hannahhuh-cog wants to merge 1 commit into
Conversation
Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Snyk SCA (scheduled scan) flagged
adm-zip@0.4.7with a Critical Zip Slip vulnerability:npm:adm-zip:20180415/ CVE-2018-1002204 (CWE-29, Arbitrary File Write via Archive Extraction).routes/index.jscallsAdmZip(importFile.data).extractAllTo(...)on user-uploaded archives, so a crafted../entry can write outside the extraction directory.Change:
package.json"adm-zip": "0.4.7"→"0.5.18"plus lockfile relock. Snyk's minimum fixed version for this CVE is 0.4.11; 0.5.18 was chosen because it also clears the two remaining High adm-zip findings (SNYK-JS-ADMZIP-1065796 directory traversal, SNYK-JS-ADMZIP-17954277 / CVE-2026-39244 resource exhaustion). TheAdmZip(buffer)/extractAllToAPI used here is unchanged in 0.5.x.Snyk reference:
npm:adm-zip:20180415, severity critical, direct dependency, manifestpackage.json.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/178f11f2b5e94e8f93f691287e1f1d60
Open in Devin Desktop: https://app.devin.ai/desktop/session/178f11f2b5e94e8f93f691287e1f1d60?variant=devin
Requested by: @hannahhuh-cog