fix(deps): upgrade adm-zip 0.4.7 → 0.5.18 — Zip Slip arbitrary file write CVE-2018-1002204 - #272
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Also closes SNYK-JS-ADMZIP-1065796 (fixed 0.5.2) and CVE-2026-39244 (fixed 0.5.18). Co-Authored-By: sumit.shatwara <sumitshatwara@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates Arbitrary File Write via Archive Extraction (Zip Slip) in the direct dependency
adm-zip@0.4.7(npm:adm-zip:20180415/ CVE-2018-1002204, severity Critical, CVSS 9.4).adm-zipis used byroutes/index.jsexports.import→zip.extractAllTo("/tmp/extracted_files", true)on user-uploaded archives, so a crafted../entry could write outside the extraction directory.adm-zip< 0.4.11 — Fixed in:0.4.11. Landing0.5.18rather than the minimum because the same package also carriesSNYK-JS-ADMZIP-1065796(Directory Traversal, High 7.4, fixed 0.5.2) andCVE-2026-39244(High 8.7, fixed 0.5.18); 0.5.18 was published 2026-06-29 and is API-compatible (AdmZip(buffer)/extractAllTounchanged).Files changed:
package.json,package-lock.json(adm-zip only; no other resolution changes).Verification:
npm ciclean; 30/30 end-to-end regression checks pass, includingPOST /importwith a real.zip(extraction to/tmp/extracted_files/backup.txtconfirmed) and the CSV import path.Scan reference: Snyk MCP
snyk_sca_scan(org9e26acce-22c7-4efc-b470-21d9587f49fe) onmain@d240896, 2026-09-10.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/0b602fbece0246d2a263a9d20b275733
Open in Devin Desktop: https://app.devin.ai/desktop/session/0b602fbece0246d2a263a9d20b275733?variant=devin
Requested by: @sumitshatwara