fix: [adm-zip] Upgrade adm-zip from 0.4.7 to 0.5.18 to resolve CVE-2018-1002204 - #278
Open
hannahhuh-cog wants to merge 1 commit into
Open
hannahhuh-cog wants to merge 1 commit into
hannahhuh-cog wants to merge 1 commit into
Conversation
Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the direct dependency
adm-zip0.4.7->0.5.18(package.json + package-lock.json) to remediate the Critical Zip Slip vulnerability flagged by the scheduled Snyk SCA scan.Vulnerability
adm-zip@0.4.7(direct dependency, used inroutes/index.jsforextractAllTo)0.4.11(Snyk); upgraded to0.5.18which additionally coversSNYK-JS-ADMZIP-1065796(Directory Traversal) and CVE-2026-39244 (resource exhaustion) affecting the same package.Risk: a crafted ZIP with
../entries could write files outside the extraction directory duringzip.extractAllTo(...).Verification:
require('adm-zip')resolves 0.5.18 andextractAllTois still exported;routes/index.jsloads without module errors. Snyk breakability check rated the upgrade medium risk (stricter zip descriptor validation since 0.5.15) — exercise the/importzip flow with real archives before release.Snyk scan reference: Snyk MCP SCA scan of
COG-GTM/nodejs-goofon 2026-09-14 (org9e26acce-22c7-4efc-b470-21d9587f49fe).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/387468bb0c6d4d6dbb7183fbbb24385f
Open in Devin Desktop: https://app.devin.ai/desktop/session/387468bb0c6d4d6dbb7183fbbb24385f?variant=devin
Requested by: @hannahhuh-cog