Skip to content

Fix numerical instability in tick generation (division by zero / NaN propagation) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samanthataylor3 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

Fix numerical instability in tick generation (division by zero / NaN propagation) #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/plugins/plot/tickUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const TIME_UNITS_UTC = [
* Nicely formatted tick steps from d3-array.
*/
function tickStep(start, stop, count) {
const step0 = Math.abs(stop - start) / Math.max(0, count);
const step0 = Math.abs(stop - start) / Math.max(1, count);
let step1 = Math.pow(10, Math.floor(Math.log(step0) / Math.LN10));
const error = step0 / step1;
if (error >= e10) {
Expand All @@ -38,7 +38,7 @@ function tickStep(start, stop, count) {
* tickStep for time units - allows for snapping to 15/30 minutes and 6/12 hours, which are common intervals.
*/
function timeTickStep(start, stop, count, unitName) {
const step0 = Math.abs(stop - start) / Math.max(0, count);
const step0 = Math.abs(stop - start) / Math.max(1, count);
let step1 = Math.pow(10, Math.floor(Math.log(step0) / Math.LN10));
const error = step0 / step1;

Expand Down Expand Up @@ -220,7 +220,7 @@ export function getLogTicks(start, stop, mainTickCount = 8, secondaryTickCount =
const secondaryLogTicks = ticks(
tick + rangeBetweenMainTicks / (secondaryTickCount + 1),
nextTick - rangeBetweenMainTicks / (secondaryTickCount + 1),
secondaryTickCount - 2
Math.max(1, secondaryTickCount - 2)
).map((n) => symlog(n, 10));

result.push(...secondaryLogTicks);
Expand All @@ -235,6 +235,10 @@ export function getLogTicks(start, stop, mainTickCount = 8, secondaryTickCount =
* Linear tick generation from d3-array.
*/
export function ticks(start, stop, count) {
if (count < 1) {
return [];
}

const step = tickStep(start, stop, count);
const precision = getPrecision(step);

Expand Down