fix(file-service): restore share notification publishing

[devin-ai-integration]

Summary

Symptom and blast radius. New file shares returned HTTP 500 while publishing file_shared, so recipients missed notifications and the UI reported that sharing failed. Any deployment inheriting the file-service image default was affected.

Root cause (config/env defect). The image baked FILE_SHARE_EVENT_ALWAYS_FAIL=true, causing EventPublisher::file_shared to replace the configured SNS_TOPIC_ARN with a nonexistent -v2 topic and surface the SNS rejection.

Fix. Remove the enabled image default so the runtime keeps SnsConfig's safe false default and publishes to the configured topic. Add image_does_not_force_share_event_failures to reject enabled Docker ENV defaults, including multi-assignment and backslash-continued declarations.

Verification. Rebuilt the image and recreated file-service without Compose's masking override; the image and running container contain no FILE_SHARE_EVENT_ALWAYS_FAIL. cargo fmt --check, all 25 tests, and cargo clippy --all-targets -- -D warnings pass. In the browser, sharing Team Offsite Agenda.txt with admin@otterworks.dev returned HTTP 201, persisted recipient access after reload, published file_shared to the configured topic, and produced the recipient notification through LocalStack SNS/SQS.

Post-fix browser recording

Recipient-side UI was not exercised; delivery was verified through the notification store and consumer logs. The fork's Helm default is intentionally unchanged because live tenant deployments use the upstream-owned runner chart and do not pass this key; changing it here would not affect the incident deployment path.

Related independent remediations remain untouched, including #245, #248, and #251–#259.

Link to Devin session: https://app.devin.ai/sessions/3f77dd83f4924148824c1480b580983b

---

Devin Review

Status	Commit
⚪ Not started	—

Run Devin Review

---

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring