fix(file-service): restore configured S3 uploads - #269
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
Runtime verificationThe browser upload passed through the React client and API gateway with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
500 storage_errorfor every user running the affected file-service deployment because writes are sent to a nonexistent S3 bucket.FILE_UPLOAD_ALWAYS_FAIL, overriding the application's safe default and redirecting uploads away fromS3_BUCKET.false, guard both production configuration surfaces withproduction_deployments_do_not_force_upload_failures, and update operator recovery guidance to match the healthy defaults while preserving explicit per-tenant overrides.FILE_UPLOAD_ALWAYS_FAILgenuinely unset; the uploaded file was visible, openable, downloadable, and searchable. Screen recording.cargo test(25 passed),cargo fmt --check,cargo clippy --all-targets -- -D warnings, script/YAML validation, and Helm template rendering also pass.Independent incident run; compare with #267. This version additionally fixes and regression-tests the Helm deployment default and refreshes its operator guidance.
Link to Devin session: https://app.devin.ai/sessions/8ce85ee2f7784df090e3f3d1ddaf9e7f
Open in Devin Desktop: https://app.devin.ai/desktop/session/8ce85ee2f7784df090e3f3d1ddaf9e7f?variant=devin
Devin Review