TTRWRKS-19: Migrate report-service to Java 17 / Spring Boot 3.2 - #272
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…oc OpenAPI bean, CI on Temurin 17, docs
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts
services/report-serviceover from Java 8 / Spring Boot 2.5.15 to Java 17 / Spring Boot 3.2.12 (TTRWRKS-19). First commit is pure OpenRewrite (org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_2:javax→jakarta, JUnit 4→5, Security 5→6, HttpClient 4→5, Java 17 build target, SpringFox→springdoc); second commit is the hand-fix sweep for what the recipe left behind. No behavior or API changes; no language modernization.Hand fixes the recipe couldn't do:
SecurityConfig— recipe emitted Security 6 DSL but left removed APIs:/swagger-resources/**,/v2/api-docs/**) to springdoc's (/swagger-ui.html,/v3/api-docs/**), otherwise the docs endpoints 401.AppConfig—HttpComponentsClientHttpRequestFactory.setReadTimeoutno longer exists; the read timeout now rides on the HttpClient 5 pool asConnectionConfig.setSocketTimeout(...), sootterworks.report.read-timeoutkeeps working.SwaggerConfig— the recipe deleted theDocketbean but left an orphanedInfohelper, so the service would have served the default (untitled) OpenAPI doc; re-exposed as@Bean OpenAPI.pom.xml— dropped the recipe's redundant pins the Boot parent manages (httpclient5.version, surefire), removed deadspringfox/commons-langproperties and thejunit-jupiterexclusion.application.properties— removed the SpringFoxspring.mvc.pathmatch.matching-strategy=ant-path-matcherworkaround and the explicithibernate.dialect(Hibernate 6 auto-detects and warns on it); unquotedspringdoc.packages-to-scan, which the recipe wrote with literal quotes.ci.ymlreport-service job and thedocker-build.ymltest gate on Temurin 17 with Maven caching (mvn -B verifyinstead of the compile/test/package trio).No
javax.*imports remain. Follow-ups (deliberately out of scope): iText 5 → OpenPDF, POI 4 → 5.2, Guava 28 → 33, commons-io bump, and re-enabling Trivy scanning for this service.Supersedes the earlier in-flight attempt in #6 (that branch also touched legacy-portal).
Link to Devin session: https://app.devin.ai/sessions/1f2e94e7f53346bdb383f4db144a82de
Open in Devin Desktop: https://app.devin.ai/desktop/session/1f2e94e7f53346bdb383f4db144a82de?variant=devin