Upgrade Java toolchain from 11 to 18 - #1023
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Bump source/target compatibility to 18, Gradle wrapper to 7.6.4, Spotless to 6.25.0, and restore CI workflow on JDK 18. Co-Authored-By: Safwan Masood <safwan.masood@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the project to Java 18:
source/targetCompatibility = '18', Gradle wrapper 7.4 → 7.6.4 (7.4 does not support Java 18), README updated.Two things beyond the mechanical version bumps:
IllegalAccessError: ... cannot access com.sun.tools.javac.parser.Tokens$TokenKind ... jdk.compiler does not export com.sun.tools.javac.parser). Bumped to 6.25.0, which runs google-java-format with the required--add-exports. No Lombok / Spring Boot / DGS bumps were needed —clean buildand all 68 tests pass as-is on JDK 18.spotlessCheckhad a pre-existing violation inDefaultJwtServiceTest(also fails on master under Java 11; CI only ranclean test, which skipscheck). Applied the one-line reformat soclean buildis green..github/workflows/gradle.ymldid not exist — it was deleted in 4b920b0 ("Remove GitHub Actions CI workflow"). Restored it from that commit withSet up JDK 18/java-version: '18'.Verified locally on OpenJDK 18.0.2:
./gradlew clean build(68 tests, 0 failures) and./gradlew bootRun→curl localhost:8080/tagsreturns{"tags":[]}.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/8f735c62b2d243219999bdba32bcd4fc
Requested by: @safwan-cognition
Note
Devin errored when opening this Pull Request as safwan-cognition.
As a fallback, Devin opened this PR as itself.
Devin Review