Skip to content

Upgrade project from Java 11 to Java 17 - #1057

Open
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1787910175-java-17-upgrade
Open

devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1787910175-java-17-upgrade

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 28, 2026

Copy link
Copy Markdown

Summary

Moves the build to Java 17 (sourceCompatibility/targetCompatibility 11 -> 17).

The only real incompatibility was Spotless: googleJavaFormat() at Spotless 6.2.1 resolves an old google-java-format that reaches into com.sun.tools.javac.*, which JDK 16+ no longer opens, so spotlessJavaCheck failed with an access error before any compilation problem. Fixed by bumping the plugin to 6.25.0 and pinning googleJavaFormat('1.15.0'); the newer formatter rewraps one line in DefaultJwtServiceTest (the entire formatting churn from the bump).

Everything else was already Java 17-clean at its current version — no changes needed to Spring Boot 2.6.3, DGS codegen 5.0.6 / graphql-dgs-spring-boot-starter:4.9.21, Lombok (1.18.22 via the Boot BOM), sqlite-jdbc:3.36.0.3, or the Gradle 7.4 wrapper.

Verified on OpenJDK 17.0.19 / Gradle 7.4: generateJava succeeds, clean build passes with 68 tests green, and bootRun starts (Started RealWorldApplication, GET /tags -> 200).

Devin-Org: engineering

Link to Devin session: https://app.devin.ai/sessions/201fafd3ea2a418cb34e89b0e9a7a1c5
Open in Devin Desktop: https://app.devin.ai/desktop/session/201fafd3ea2a418cb34e89b0e9a7a1c5?variant=devin


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Devin Review (Staging)
Devin Review

Co-Authored-By: thomas.blake <tom.blakey22@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants