Upgrade project from Java 11 to Java 17 - #1057
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: thomas.blake <tom.blakey22@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the build to Java 17 (
sourceCompatibility/targetCompatibility11->17).The only real incompatibility was Spotless:
googleJavaFormat()at Spotless 6.2.1 resolves an old google-java-format that reaches intocom.sun.tools.javac.*, which JDK 16+ no longer opens, sospotlessJavaCheckfailed with an access error before any compilation problem. Fixed by bumping the plugin to 6.25.0 and pinninggoogleJavaFormat('1.15.0'); the newer formatter rewraps one line inDefaultJwtServiceTest(the entire formatting churn from the bump).Everything else was already Java 17-clean at its current version — no changes needed to Spring Boot 2.6.3, DGS codegen 5.0.6 /
graphql-dgs-spring-boot-starter:4.9.21, Lombok (1.18.22 via the Boot BOM),sqlite-jdbc:3.36.0.3, or the Gradle 7.4 wrapper.Verified on OpenJDK 17.0.19 / Gradle 7.4:
generateJavasucceeds,clean buildpasses with 68 tests green, andbootRunstarts (Started RealWorldApplication,GET /tags-> 200).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/201fafd3ea2a418cb34e89b0e9a7a1c5
Open in Devin Desktop: https://app.devin.ai/desktop/session/201fafd3ea2a418cb34e89b0e9a7a1c5?variant=devin
Devin Review