bug: upgrade Spring Framework to 5.3.39 (CVE-2022-22965 and related) - #1064
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Spring Boot 2.6.3 BOM resolves Spring Framework to 5.3.15, which is affected by CVE-2022-22965 (Spring4Shell, fixed 5.3.18), CVE-2022-22968 (fixed 5.3.19), CVE-2022-22950 / CVE-2023-20863 (SpEL DoS, fixed 5.3.27) and CVE-2024-22243 / CVE-2024-22262 (
UriComponentsBuilderhost parsing, fixed 5.3.34).This pins the BOM-managed framework version to the last 5.3.x release, which covers all of the above:
spring-framework.versionis the property the Spring Boot BOM uses forspring-core/spring-web/spring-beans/etc., so this bumps every Spring Framework artifact at once; 5.3.x patch releases are binary-compatible, so no source changes are needed.Why not bump Spring Boot to 2.7.x, as the finding suggests: the project depends on
graphql-dgs-spring-boot-starter:4.9.21, and DGS only supports Spring Boot 2.7 from 5.5.x onwards (and drops Boot 2 entirely in 6.x). Boot 2.7's own framework version is 5.3.31 — older than what is pinned here — so a Boot bump would pull in a DGS/Spring Security major upgrade without closing any additional CVE from this finding. Keeping the change scoped to the framework version is the smaller, fully-covering fix.Verification: Maven Central and the Gradle plugin portal are outside this session's network allowlist and there is no Gradle offline cache for this project, so
./gradlew compileJava/./gradlew testcould not be run here (the repo also has no CI workflow). The change is a single BOM property override with no API surface change.Written by Devin
Devin-Org: engineering