feature: add unit tests for untested layers and JaCoCo coverage report - #1069
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for previously untested code and wires up JaCoCo so coverage is measurable going forward.
build.gradle:jacocoplugin;testisfinalizedBy jacocoTestReport(xml + html underbuild/reports/jacoco/test/).Util,CursorPager,CursorPageParameter(limit clamping to 1000 / default 20),DateTimeCursor(millis round-trip, UTC),User.update(empty values leave fields untouched),Comment.ArticleCommandService,UserService(password encoding, default image).JwtTokenFilter: header parsing edge cases, missing user, and that an existingSecurityContextauthentication is not overwritten — mocks injected viaReflectionTestUtilssince the filter uses field injection.TagsApi(@WebMvcTest) andTagDatafetcher(first GraphQL test, viaDgsQueryExecutorwithDgsAutoConfiguration).JaCoCo overall: 33% → 36% instruction coverage (denominator includes the generated DGS types, which drags the number down; the newly covered classes go to ~100%).
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/f12ea9326fb649f4b3da48e6cca71461
Open in Devin Desktop: https://app.devin.ai/desktop/session/f12ea9326fb649f4b3da48e6cca71461?variant=devin
Requested by: @shayanshafii