Conversation
Co-Authored-By: Yubin Jee <yubinjee0310@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Yubin Jee <yubinjee0310@gmail.com>
…iation Co-Authored-By: Yubin Jee <yubinjee0310@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the app off EOL Spring Boot 2.6.3 onto Spring Boot 3.5.16 with a Java 17 toolchain and Gradle 8.5.
Non-obvious parts of the upgrade:
WebSecurityConfigno longer extendsWebSecurityConfigurerAdapter; it exposes aSecurityFilterChainbean with the lambda DSL (authorizeHttpRequests/requestMatchers). Rules,HttpStatusEntryPoint(401), stateless sessions, CORS source andJwtTokenFilterplacement beforeUsernamePasswordAuthenticationFilterare unchanged.javax.servlet.*/javax.validation.*→jakarta.*everywhere insrc(javax.cryptois JDK and untouched).graphql-dgs-spring-boot-starter:4.9.21→ DGS platform BOM 9.2.2 +graphql-dgs-spring-graphql-starter(DGS now runs on Spring for GraphQL). Consequences:graphql.relay.DefaultPageInfois no longer accepted for the codegen'dPageInfotype, soArticleDatafetcher/CommentDatafetcherbuildio.spring.graphql.types.PageInfodirectly.DataFetcherExceptionHandler.onException→handleException(...)returningCompletableFuture.GraphQlJacksonConfiguration: the app setsspring.jackson.deserialization.UNWRAP_ROOT_VALUE=truefor the REST payload envelope ({"user": {...}}), which broke deserialization of Spring GraphQL'sSerializableGraphQlRequest. It registers a copy of theObjectMapperwith that feature disabled for just that request type.flyway-corestays Boot-managed (Flyway 11 keeps SQLite in core,flyway-database-sqliteisn't published).CustomizeExceptionHandlersignature:HttpStatus→HttpStatusCode(Spring 6ResponseEntityExceptionHandler).Verified:
./gradlew spotlessJavaApply && ./gradlew clean build(68 tests pass), plusbootRunsmoke:GET /tags200,GET /user401,POST /graphql {__typename}200.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/222ad18312c342b8a08bb4c917347188
Open in Devin Desktop: https://app.devin.ai/desktop/session/222ad18312c342b8a08bb4c917347188?variant=devin
Requested by: @yubin-jee