Add JUnit 4 unit tests for TopicService - #55
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
Test results — all 15 tests pass ✅Ran the full suite
Note: Tested by Devin: https://app.devin.ai/sessions/7d9ce4715bd240c689e7fe5259a0e560 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the project's first tests:
src/test/java/hello/service/TopicServiceTest.java, 15 JUnit 4 characterization tests covering the deterministic, in-memory logic ofTopicService(seeded idsspring,java,javascript). Each test constructsnew TopicService()in@Before, so they document current behavior without touching production code.Coverage:
getAllTopics,getTopicWithId(incl.NoSuchElementExceptionfor an unknown id — documents the no-fallback.findFirst().get()),addTopic,updateTopic(replace + no-op for unknown id),deleteTopic(remove + no-op),filterMinimumLengthForId(strict>+ boundaries),sortTopicsWithID,returnAllTopicIDWithStringSlicing("spring:java:javascript"),makeDistinctAndSortCharacters("cba"→"abc","banana"→"abn"),splitAllIdWithColonSelectIDWithJavaKeywordThenSortThenJoin("java:javascript"), andfindIdHavingCharacter("[spring]").Build wiring:
pom.xml: addspring-boot-starter-test(testscope).build.gradle: replacetestCompile("junit:junit")withtestCompile("org.springframework.boot:spring-boot-starter-test").build.gradlealso gainedspring-boot-starter-jdbc+com.h2database:h2(already present inpom.xml). These are required — without them Gradle'scompileJavafails (Application.javaimportsorg.springframework.jdbc.core.JdbcTemplate), which blocked compiling/running any test.Verification
./gradlew test→BUILD SUCCESSFUL, 15 tests, 0 failures (run with JDK 8, matching Spring Boot 2.0.2 / Gradle 4.6).Note:
pom.xmluses<packaging>pom</packaging>, somvn testbinds no compile/surefire and executes no tests — thespring-boot-starter-testdep is wired in as requested, but Gradle is the effective test runner here.Link to Devin session: https://app.devin.ai/sessions/7d9ce4715bd240c689e7fe5259a0e560
Requested by: @patrickbradley-cog
Devin Review