Skip to content

Upgrade to Java 17 and Spring Boot 3.3.5 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobydrinkall wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to Java 17 and Spring Boot 3.3.5 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94f7edf
Upgrade to Java 17 and Spring Boot 3.3.5
devin-ai-integration[bot] Jul 30, 2026
f0bb03b
Address review: drop properties-migrator, plain source/target 17, reg…
devin-ai-integration[bot] Jul 30, 2026
2f91e47
Address review: non-fatal quote fetch, Maven/Gradle dependency parity…
devin-ai-integration[bot] Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .mvn/wrapper/maven-wrapper.jar
View file
Open in desktop
Binary file not shown.
4 changes: 3 additions & 1 deletion .mvn/wrapper/maven-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.3.9/apache-maven-3.3.9-bin.zip
wrapperVersion=3.3.4
distributionType=only-script
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip
41 changes: 22 additions & 19 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,35 @@
buildscript {
repositories {
mavenCentral()
}
dependencies {
classpath("org.springframework.boot:spring-boot-gradle-plugin:2.0.2.RELEASE")
}
plugins {
id 'java'
id 'eclipse'
id 'idea'
id 'org.springframework.boot' version '3.3.5'
id 'io.spring.dependency-management' version '1.1.6'
}

apply plugin: 'java'
apply plugin: 'eclipse'
apply plugin: 'idea'
apply plugin: 'org.springframework.boot'
apply plugin: 'io.spring.dependency-management'
group = 'org.springframework'
version = '0.1.0'

java {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
}

bootJar {
baseName = 'gs-spring-boot'
version = '0.1.0'
archiveBaseName = 'gs-spring-boot'
archiveVersion = '0.1.0'
}

repositories {
mavenCentral()
}

sourceCompatibility = 1.8
targetCompatibility = 1.8

dependencies {
compile("org.springframework.boot:spring-boot-starter-web")
testCompile("junit:junit")
implementation 'org.springframework.boot:spring-boot-starter-web'
implementation 'org.springframework.boot:spring-boot-starter-jdbc'
runtimeOnly 'com.h2database:h2'
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment on lines 26 to +29

@devin-ai-integration devin-ai-integration Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Gradle and Maven builds now agree on dependencies, but h2 scoping differs subtly

Maven declares h2 with runtime scope and Gradle uses runtimeOnly, which are equivalent for this app since no source touches H2 APIs. Note the Maven side previously had h2 at compile scope; narrowing it is safe here only because there are no H2 imports in src/. Similarly, no explicit test { useJUnitPlatform() } is needed in build.gradle because the Spring Boot Gradle plugin configures it, and there are currently no tests under src/test.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on all three points. H2 narrowing is safe — rg 'org\.h2' src/ finds nothing, it's purely a JDBC-URL-driven runtime dependency. I'll leave test { useJUnitPlatform() } in place: it's redundant with the Boot plugin today but harmless, and it makes the intent explicit for whoever adds the first test.

testImplementation 'org.springframework.boot:spring-boot-starter-test'
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
}

test {
useJUnitPlatform()
}
Binary file modified gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
5 changes: 3 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#Thu Mar 01 09:01:15 CST 2018
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-bin.zip
Loading