Upgrade from Java 8 to Java 11 (Spring Boot 2.7.18, Gradle 7.6.4) - #63
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project to build and run on Java 11, keeping Maven and Gradle definitions in sync:
pom.xml:java.version1.8 → 11,spring-boot-starter-parent2.0.2.RELEASE → 2.7.18 (last 2.x line, officially supports Java 11).spring-boot-properties-migratorkept for now; startup logs show no property-migration warnings, so it can be removed in a follow-up. Also changed<packaging>pom</packaging>→jar— withpompackaging Maven never compiled the sources, so the Java 11 build could not actually be verified.build.gradle:spring-boot-gradle-plugin→ 2.7.18,sourceCompatibility/targetCompatibility→JavaVersion.VERSION_11,compile/testCompile→implementation/testImplementation,bootJar { baseName/version }→archiveBaseName/archiveVersion(removed in Gradle 7). Addedspring-boot-starter-jdbc,h2, andspring-boot-properties-migratorto match the Maven dependency set (Gradle build previously lacked them andApplication.java'sJdbcTemplateusage failed to compile).gradlew/mvnwmade executable.Application.java: wrapped the startupRestTemplatecalls togturnquist-quoters.cfapps.ioin try/catch — that service is long dead (UnknownHostException), and with Spring Boot 2.7 the failingCommandLineRunneraborted application startup. No other source changes were needed; no removed Java 8 APIs are used.Verification (JDK 11.0.28)
./mvnw clean verify— BUILD SUCCESS (sources compiled, jar packaged)./gradlew clean build— BUILD SUCCESSFULjava -jar target/gs-spring-boot-0.1.0.jar);GET /,GET /topic,GET /datetimeall respond correctly; no properties-migrator warnings in logs.Link to Devin session: https://app.devin.ai/sessions/ea4c7c6a661f4c73b3b83b66302fab93
Devin Review