Upgrade build to Java 11 / Spring Boot 2.7.18 / Gradle 7.6.4 - #80
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Bryce Hunt <bryce@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…quisite Co-Authored-By: Bryce Hunt <bryce@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Java 8 → 11 across both build systems, with the coordinated bumps needed for Java 11 support:
pom.xml:java.version1.8 → 11,spring-boot-starter-parent2.0.2.RELEASE → 2.7.18. Also<packaging>pom</packaging>→jar— withpompackaging Maven never compiledsrc/main/javaat all, so the build "passed" without exercising the sources or producing an artifact.build.gradle:sourceCompatibility/targetCompatibility→ 11 plusoptions.release = 11(enforces the Java 11 API surface on newer JDKs),spring-boot-gradle-plugin→ 2.7.18,compile/testCompile→implementation/testImplementation,bootJar { baseName/version }→archiveBaseName/archiveVersion(old properties removed in Gradle 7/8). Addedspring-boot-starter-jdbc,h2, andspring-boot-properties-migratorto match the pom —Application.javaimportsJdbcTemplate, so the Gradle build did not compile without them.gradle/wrapper/gradle-wrapper.properties: Gradle 4.6 → 7.6.4.gradlew/mvnw: made executable. README prerequisite updated to Java 11.No Java source changes were needed. Verified on OpenJDK 11.0.32:
./gradlew clean buildandmvn clean packageboth succeed and producegs-spring-boot-0.1.0.jar. (./mvnwitself could not be verified here — its Maven 3.3.9 distribution download from repo1.maven.org was rate-limited with HTTP 429.)Left untouched: the defunct
gturnquist-quoters.cfapps.iocall inApplication.java(runtime-only, unrelated to the upgrade), and the trackedtarget/classes/*.classfiles.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/27eb2626eee7463397268bd04addb238
Open in Devin Desktop: https://app.devin.ai/desktop/session/27eb2626eee7463397268bd04addb238?variant=devin
Requested by: @bryce-h-t