feature(MBA-2341): raise compileSdk/targetSdk to 36 in app and components - #10
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…ames '$' is not a valid Android resource name character, so :components:packageDebugResources failed and the project could not build. Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MBA-2341
compileSdk/targetSdk34 → 36 in bothappandcomponents. 36 is the level Google Play requires for app updates since 2026‑08‑31 (37 is not yet a Play requirement and isn't installed in our build images).minSdkstays 21 — no consumer sign-off recorded yet; raising it is deferred until that lands on the ticket.app/build.gradlemoves fromcompileSdkVersion/minSdkVersion/targetSdkVersiontocompileSdk/minSdk/targetSdk(the*VersionDSL is removed in AGP 9).gradle.properties:android.suppressUnsupportedCompileSdk=36. AGP 8.7.1 is tested only up to compileSdk 35 and otherwise emits a warning on every build; remove this line once MBA-2338 (AGP upgrade) lands.devin/1788841114-fix-invalid-drawable-names(ic_currency_north_america_$_*→*_dollar_*) becausemaindoes not currently build without it; it merges cleanly whichever PR lands first.Verification
assembleDebugsucceeds, no unsupported-compileSdk warning.lintDebug: 2,724InvalidVectorPatherrors / 135 warnings incomponents— identical error count when run at compileSdk 34 on the same branch, so no new lint errors from this change (pre-existing vector-path issues, out of scope).dumpsys package:minSdk=21 targetSdk=36), no crashes in logcat.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/63bcc92ac0414d73b93027663493e7a5
Open in Devin Desktop: https://app.devin.ai/desktop/session/63bcc92ac0414d73b93027663493e7a5?variant=devin