feature: live component search in the demo app navigation drawer - #11
Open
sohankshirsagar wants to merge 4 commits into
Open
sohankshirsagar wants to merge 4 commits into
sohankshirsagar wants to merge 4 commits into
Conversation
Co-Authored-By: Sohan Kshirsagar <sohan.kshirsagar@gmail.com>
…filtered rows Co-Authored-By: Sohan Kshirsagar <sohan.kshirsagar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Sohan Kshirsagar <sohan.kshirsagar@gmail.com>
…n dark mode Co-Authored-By: Sohan Kshirsagar <sohan.kshirsagar@gmail.com>
|
Verified on an Android emulator (API level of the Drawer search verification
Limitations and pre-existing findingOne local emulator only; no physical device or alternate screen sizes. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The demo drawer lists 17 components with no way to jump to one; this adds a
ZdsSearchViewheader that filters the drawer menu as you type, so the ZDS catalog is browsable by name.NavigationSearch.attach(navView)inflates a second header (the existingnavigation_headerstays at index 0, sogetHeaderView(0)inMainActivityis unaffected) and drives the existingnavigation_drawermenu directly — no new menu model:Two non-obvious details:
syncActionView()hides an item's badge action view while the item is filtered out. Without it,NavigationView's recycler re-attaches the "24" badge from the hidden Buttons row onto whatever row lands in that position.Also renames
ic_currency_north_america_$_{round,sharp}.xml(unreferenced, added by an automated deps commit) to..._usd_...: AAPT rejects$in resource filenames, which failsassembleDebugonmaintoday.Screenshots
Drawer with the search field, filtered results, and the empty state:
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/a3b2a208d83f4550abcbbc2bfab5ae0a
Open in Devin Desktop: https://app.devin.ai/desktop/session/a3b2a208d83f4550abcbbc2bfab5ae0a?variant=devin
Requested by: @sohankshirsagar