feature(MBA-2337): add pull-request CI (build, lint, unit + instrumentation tests) - #7
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…instrumentation tests) - New .github/workflows/pull-request.yml on pull_request and push to main - Wrapper validation and Gradle cache via gradle/actions/setup-gradle - Instrumentation job on API 34 emulator with report artifact - Make gradlew executable so ./gradlew runs in CI - Rename two drawables with '$' in their names that broke packageDebugResources - Downgrade InvalidVectorPath to warning in components/lint.xml (2.7k generated icon paths)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…n time CI has no Artifactory credentials; project.property() threw during configuration and failed every Gradle task. Use findProperty with empty fallbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MBA-2337 — nothing ran on
pull_requestbefore; this adds.github/workflows/pull-request.yml(onpull_requestand push tomain):./gradlew assembleDebug→:components:assembleRelease→lint→testDebugUnitTest, JDK 17 (temurin, matcheson-release.ymland Ticket 2's target),gradle/actions/setup-gradlewithvalidate-wrappers: true(tamperedgradle-wrapper.jarfails the job) and Gradle cache (keyed by setup-gradle on wrapper/catalog/build-script hashes;cache-read-onlyoffmainso onlymainwrites). Lint/unit reports + APK/AAR uploaded as artifacts. All actions are pinned to full commit SHAs (# vX.Y.Zcomments) since this runs onpull_request.reactivecircus/android-emulator-runner, x86_64google_apisAPI 34 (= currenttargetSdk; bump the matrix when Ticket 4 lands), KVM enabled, AVD snapshot cached. Runs:app:connectedDebugAndroidTestand uploadsapp/build/reports/androidTests/connected/debug/+ XML results asandroidTest-report-api-34,if: always().Four small fixes were required for the workflow to actually be green on
main:gradlewwas committed as100644→./gradlewfails with Permission denied in CI. Now100755.ic_currency_north_america_$_{round,sharp}.xmlbreak:components:packageDebugResources($is not a valid resource name char) —maindoes not build today. Renamed to..._dollar_{round,sharp}.xml(same as closed fix: rename currency_north_america drawables to valid resource names #1; contents unchanged, nothing references them)../gradlew lintreported 2724 errors, allInvalidVectorPathin the generated icon set (-.005instead of-0.005). Addedcomponents/lint.xmldowngrading that one check towarningso lint still gates on everything else; fixing the icon generator is out of scope for this ticket. Alternative would be a 1.7 MBlint-baseline.xml.components/build.gradlepublishing.repositories.mavenusedproject.property('mavenUsername')etc., which throws at configuration time when the Artifactory properties are absent (i.e. on every CI task, not justpublish). Now the four properties (zds-android-maven,publish,mavenUsername,mavenPassword) are read withfindProperty; the repo URL is only composed when all are present (otherwise an unreachablehttps://invalid.invalid/...placeholder, never a relative path), andPublishToMavenRepositorytasks throwCannot publish: missing Gradle properties …indoFirst. Overlaps Ticket 8 (MBA-2343).Verified locally with JDK 17 and no
~/.gradle/gradle.properties:./gradlew assembleDebug :components:assembleRelease lint testDebugUnitTest→ BUILD SUCCESSFUL.testDebugUnitTestis NO-SOURCE and there are noandroidTestsources onmainyet (Ticket 6 / #4 adds them).Follow-ups (not in this PR): make
Build, lint and unit testsa required status check onmainonce green.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/61c69fb00dd543ff825286b858d5016c
Open in Devin Desktop: https://app.devin.ai/desktop/session/61c69fb00dd543ff825286b858d5016c?variant=devin