feature: add ZdsChip with selectable and filter variants - #9
Open
sohankshirsagar wants to merge 1 commit into
Open
sohankshirsagar wants to merge 1 commit into
sohankshirsagar wants to merge 1 commit into
Conversation
Co-Authored-By: Sohan Kshirsagar <sohan.kshirsagar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a chip component to the library.
ZdsChipextends Material'sChip(defStyleAttrchipStyle) and exposes achip_styleenum attr with two variants; both are checkable, and the variant only controls whether the checked icon is shown:Colors follow the existing selector pattern (
chip_background_selector,chip_stroke_selector,chip_text_selector) so unselected/selected/disabled states resolve from the ZDS palette and pick up the night-mode overrides automatically. StylesZds.Chip.Selectable/Zds.Chip.Filterinherit fromZds.Chip.Demo app gets a "Chips" screen (nav graph + drawer entry) showing a single-selection selectable group and a multi-selection filter group, each with a disabled chip.
Note:
assembleDebugfails onmainfor unrelated reasons — the twoic_currency_north_america_$_*.xmldrawables have$in their filenames, which AAPT rejects. I verified the build and:app:lintDebugpass with those two pre-existing files temporarily moved aside; they are untouched in this PR.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/0d9fe7f127704f84abe81ad81a55f123
Open in Devin Desktop: https://app.devin.ai/desktop/session/0d9fe7f127704f84abe81ad81a55f123?variant=devin
Requested by: @sohankshirsagar