Combined Overturning Circulation notebook using Intake#533
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I suggest we call the combined recipe "Meridional Overturning Circulation". And it should be mostly same as the Meridional_Overturning_Circulation.ipynb but with an extra 1-2 cell to show how to split into basins. |
|
We appear to be missing a global 0.1degree MOM6 output from the ACCESS-NRI Intake Catalog to use in what was the Meridional_Overturning_Circulation notebook. What's an appropriate dataset we could use/add? @navidcy @AndyHoggANU |
|
Good question. That 0.1° run was just a test. Do we have any global 1/4° MOM6 runs in the catalogue? If not, could use a PanAnt run (and just explain it's just a Southern Ocean domain)? |
|
@AndyHoggANU there is the |
|
Yep, that's good for demonstration purposes. |
Possibly not @AndyHoggANU - unless I'm missing something, it appears to lack a 'potential density'-equivalent variable. |
|
@adele-morrison @navidcy @aekiss can you suggest a dataset that would work? |
|
We could potentially just use TEOS-10 to generate a potential density field here - or is that bad practice to do so with models? |
|
I believe this is the last (or second-to-last) recipe to convert to intake. It would be great if we could complete this ASAP. |
|
It looks the |
|
@adele-morrison I'm not sure how that will work though - the potential density variable from the MOM5 data ( |
|
Are we now at the point where we just merge this 'as-is' and open a ticket to sort out the MOM6 data issue later? The book is adapted for intake already, although it likely needs some tidying up first. |
|
Checklist to close off for as-is merge:
|
|
Currently the notebook can't be run the whole way through in one hit without errors - will update and merge when this is the case. |
|
@marc-white It won't let me request a review from you - presumably because this PR was yours originally - but can you review my changes & check you're happy with them? |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:40Z Line #21. # "attrs": {"cell_methods": "rho2_l:sum yq:point xh:sum time: mean"},
Could this be removed? |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:41Z Was this in the original notebook? I can't recall... charles-turner-1 commented on 2025-07-16T21:57:41Z Nah - I added this in to show why a subsequent cell is broken |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:41Z This looks.... odd. Is this what we'd expect? charles-turner-1 commented on 2025-07-16T21:59:41Z This is why the cell below fails - the depth mapping calculation is wrong for MOM6.
I'm adding a bit more exposition now. |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:42Z This is showing up as a blank plot on the ReviewNB view, please check. charles-turner-1 commented on 2025-07-16T22:01:09Z Yup, that's correct - Added a note explaining this. |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:42Z Data location to be removed, replace with intake words |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:43Z Not for action, but we really need to work out a more efficient way to load in these time-invariant values. charles-turner-1 commented on 2025-07-16T22:03:50Z agreed |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2025-07-16T07:04:44Z Can remove commented parts |
|
Nah - I added this in to show why a subsequent cell is broken View entire conversation on ReviewNB |
|
This is why the cell below fails - the depth mapping calculation is wrong for MOM6.
I'm adding a bit more exposition now. View entire conversation on ReviewNB |
|
Yup, that's correct - Added a note explaining this. View entire conversation on ReviewNB |
|
agreed View entire conversation on ReviewNB |
|
Thanks for catching those issues @marc-white. Currently, it looks like that calculation that remaps density space back to depth space is wrong for MOM6. I'm going to take a quick look to see it it's an easy fix - it not I've put some comments surrounding what's going wrong in that suggest taking a look at the cosima hackathon. |
|
I've mostly fixed the depth calculation. I think it's still a little dodgy - I've added a comment about this - but it should function pretty well as a recipe now. Think it's ready to merge. |
rbeucher
left a comment
rbeucher
left a comment
There was a problem hiding this comment.
Just make sure that remaining issues are documented and flagged in a GitHub issue for the Hackathon. Thanks for your help on this.
…ccidentally undeleted
* Remove errant references to cosima cookbook * Delete basin wise overturning circulation, see #533. Think this got accidentally undeleted * 'cosima_cookbook user'=> 'cookbook user' in comment for greppability * Remove cookbook tutorials * Typo * Fix the barotropic steamfunction notebook
6 participants
Closes #435 , progresses #313 .
This PR will combine the existing notebooks
Recipes/Appetisers-Easy/Atlantic_IndoPacific_Basin_Overturning_Circulation.ipynbandRecipes/Appetisers-Easy/Meridional_Overturning_Circulation.ipynbinto a single notebook,Recipes/Appetisers-Easy/Overturning_Circulation.ipynb, that uses Intake instead of COSIMA Cookbook.