Skip to content

Improvements to Along_slope_velocities.ipynb#645

Merged
navidcy merged 6 commits into
COSIMA:mainfrom
julia-neme:jn_along_slope_velocities
Dec 19, 2025
Merged

Improvements to Along_slope_velocities.ipynb#645
navidcy merged 6 commits into
COSIMA:mainfrom
julia-neme:jn_along_slope_velocities

Conversation

@julia-neme
Copy link
Copy Markdown
Collaborator

Closes #576

I have added mom6 instructions (there's placeholder there to link to the new tutorial on grids and xgcm #621 which adaptation to MOM6 in this recipe will need),

I have removed all the detailed browsing of the catalogue since that should be covered in the intake tutorial notebook, and I have also removed the vertical averaging section because its not pertinent for this recipe. This way the recipe is more clearly focused is on along-topography projection of a velocity (or other vector) field. I can create another tutorial for correct vertical averaging if not already somewhere.

Last, there's some tweaks and improvements to the text.

…ot pertinent for this recipe, opened grid information in a more intuitive way, cleaned and enhanced text
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@julia-neme julia-neme changed the title Improvements to `Along_slope_velocities.ipynb Improvements to Along_slope_velocities.ipynb Nov 10, 2025
@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Nov 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-11-10T05:18:01Z
----------------------------------------------------------------

Line #1.    # from pathlib import Path

if we don't need Path then delete the line?

Also, what's the error here?

ERROR 1: PROJ: proj_create_from_database: Open of /g/data/xp65/public/./apps/med_conda/envs/analysis3-25.09/share/proj failed

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Nov 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-11-10T05:18:02Z
----------------------------------------------------------------

what's this weird output (at last at reviewnb is weird!)


julia-neme commented on 2025-11-11T00:22:20Z
----------------------------------------------------------------

I have no idea what this is but it does not appear in the jupyter notebook..

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Nov 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-11-10T05:18:03Z
----------------------------------------------------------------

Line #7.    # Take the mean over time

no need to explain that .mean('time') is the mean over time; it's quite self-explanatory


@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Nov 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-11-10T05:18:03Z
----------------------------------------------------------------

the output is a bunch of errors...............?


@julia-neme
Copy link
Copy Markdown
Collaborator Author

Upsi daisies I wrote about those errors here: #576 (comment)

I've been using VS Code because ARE's jup lab glitches are driving me crazy - downsize is those strange warnings (I've asked in the hive). I'll re-run in ARE and push again

@navidcy
Copy link
Copy Markdown
Collaborator

navidcy commented Nov 10, 2025

I tried to run via gadi_jupyter and was getting errors........ I'll wait for your push and see what happens.

@julia-neme julia-neme force-pushed the jn_along_slope_velocities branch from f607219 to b4e5d83 Compare November 10, 2025 22:38
Copy link
Copy Markdown
Collaborator Author

I have no idea what this is but it does not appear in the jupyter notebook..


View entire conversation on ReviewNB

@julia-neme
Copy link
Copy Markdown
Collaborator Author

I think ready for you @navidcy :)

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Dec 19, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-12-19T23:39:33Z
----------------------------------------------------------------

Line #9.    # # For plotting

why do we need 2 # ?


@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Dec 19, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-12-19T23:39:33Z
----------------------------------------------------------------

Line #5.    esm_ds = catalog[experiment]

we don't need a comment to say that we named something esm_ds

but what's esm? why do that?


@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Dec 19, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-12-19T23:39:34Z
----------------------------------------------------------------

Line #28.                             vmin=-0.5, vmax=0.5, extend='both',

the 0.3 colorbar limits looked better?


@navidcy
Copy link
Copy Markdown
Collaborator

navidcy commented Dec 19, 2025

I pushed some tweaks. Looks good! I'll merge.

@navidcy navidcy merged commit 55ca3f9 into COSIMA:main Dec 19, 2025
2 checks passed
@julia-neme julia-neme deleted the jn_along_slope_velocities branch December 29, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MOM6 instructions to Along-slope-velocities.ipynb

2 participants