warnings: Fix clang generated warnings

CMakeLists.txt

@@ -261,7 +261,11 @@ add_compile_options(
     -Wcast-qual
     -Wno-system-headers
     -Wno-unused-function
-    -Wno-stringop-truncation
+    $<$<AND:$<COMPILE_LANGUAGE:C>,$<C_COMPILER_ID:Clang>>:-Wno-gnu-statement-expression-from-macro-expansion>
+    $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:Clang>>:-Wno-gnu-statement-expression-from-macro-expansion>
+    $<$<CXX_COMPILER_ID:Clang>:-Wno-gnu-zero-variadic-macro-arguments>
+    $<$<AND:$<COMPILE_LANGUAGE:C>,$<C_COMPILER_ID:GNU>>:-Wno-stringop-truncation>
+    $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:GNU>>:-Wno-stringop-truncation>
 )
 
 if(WITH_DOC STREQUAL "OFF")

examples/example1/example1.c

@@ -50,7 +50,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa1)
 
-int main()
+int main(void)
 {
     struct timespec ts;
 

examples/example1_v2/example1.c

@@ -50,7 +50,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa1);
 
-int main()
+int main(void)
 {
     struct timespec ts;
 

examples/example2/example2.c

@@ -52,7 +52,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa2)
 
-int main()
+int main(void)
 {
     int num;
     struct timespec ts;

examples/example2_v2/example2.c

@@ -52,7 +52,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa2);
 
-int main()
+int main(void)
 {
     int num;
     struct timespec ts;

examples/example3/example3.c

@@ -52,7 +52,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa3)
 
-int main()
+int main(void)
 {
     int num;
     struct timespec ts;

examples/example3_v2/example3.c

@@ -52,7 +52,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa3);
 
-int main()
+int main(void)
 {
     int num;
     struct timespec ts;

examples/example4/example4.c

@@ -50,7 +50,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa1)
 
-int main()
+int main(void)
 {
     unsigned char buffer[256];
     int num;

examples/example4_v2/example4.c

@@ -50,7 +50,7 @@
 
 DLT_DECLARE_CONTEXT(con_exa1);
 
-int main()
+int main(void)
 {
     unsigned char buffer[256];
     int num;

src/console/dlt-control-v2.c

@@ -129,7 +129,7 @@ typedef struct {
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/console/dlt-passive-node-ctrl.c

@@ -118,7 +118,7 @@ void set_node_id(char *id)
     }
 }
 
-char *get_node_id()
+char *get_node_id(void)
 {
     return g_options.node_id;
 }
@@ -211,7 +211,7 @@ static int dlt_passive_node_analyze_response(char *answer,
  *
  * @return Pointer ot DltControlMsgBody, NULL otherwise
  */
-DltControlMsgBody *dlt_passive_node_prepare_message_body()
+DltControlMsgBody *dlt_passive_node_prepare_message_body(void)
 {
     DltControlMsgBody *mb = calloc(1, sizeof(DltControlMsgBody));
     char *ecuid = get_node_id();
@@ -271,7 +271,7 @@ void dlt_passive_node_destroy_message_body(DltControlMsgBody *msg_body)
  *
  * @return 0 on success, -1 on error
  */
-static int dlt_passive_node_ctrl_single_request()
+static int dlt_passive_node_ctrl_single_request(void)
 {
     int ret = -1;
 
@@ -301,7 +301,7 @@ static int dlt_passive_node_ctrl_single_request()
     return ret;
 }
 
-static void usage()
+static void usage(void)
 {
     printf("Usage: dlt-passive-node-ctrl [options]\n");
     printf("Send a trigger to DLT daemon to (dis)connect a passive node "

src/console/dlt-receive-v2.c

@@ -144,7 +144,7 @@ typedef struct {
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/console/dlt-sortbytimestamp.c

@@ -194,7 +194,7 @@ void write_messages(int ohandle, DltFile *file,
 /**
  * Print usage information of tool.
  */
-void usage() {
+void usage(void) {
     char version[DLT_VERBUFSIZE];
 
     dlt_get_version(version, DLT_VERBUFSIZE);

src/console/logstorage/dlt-logstorage-ctrl.c

@@ -354,7 +354,7 @@ static int dlt_logstorage_ctrl_setup_event_loop(void)
  *
  * @return 0 on success, -1 otherwise.
  */
-static int dlt_logstorage_ctrl_single_request()
+static int dlt_logstorage_ctrl_single_request(void)
 {
     int ret = 0;
 

src/daemon/dlt-daemon.c

@@ -207,7 +207,7 @@ void close_pipes(int fds[2])
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[DLT_DAEMON_TEXTBUFSIZE];
     dlt_get_version(version, DLT_DAEMON_TEXTBUFSIZE);
@@ -2490,7 +2490,7 @@ void dlt_daemon_local_cleanup(DltDaemon *daemon, DltDaemonLocal *daemon_local, i
     free(daemon_local->flags.ipNodes);
 }
 
-void dlt_daemon_exit_trigger()
+void dlt_daemon_exit_trigger(void)
 {
     /* stop event loop */
     g_exit = -1;
@@ -2656,7 +2656,7 @@ int dlt_daemon_log_internal(DltDaemon *daemon, DltDaemonLocal *daemon_local,
 
         msg.storageheadersizev2 = (uint32_t)(STORAGE_HEADER_V2_FIXED_SIZE + strlen(DLT_DAEMON_ECU_ID));
         msg.baseheadersizev2 = BASE_HEADER_V2_FIXED_SIZE;
-        msg.baseheaderextrasizev2 = (int32_t)dlt_message_get_extraparameters_size_v2(msgcontent);
+        msg.baseheaderextrasizev2 = (uint32_t)dlt_message_get_extraparameters_size_v2(msgcontent);
         /* Ecu Id, App Id, Ctx Id and Session Id*/
         msg.extendedheadersizev2 = (uint32_t)(1 + strlen(DLT_DAEMON_ECU_ID) + 1 + strlen(app_id) + 1 + strlen(ctx_id) + sizeof(uint32_t));
 

src/daemon/dlt-daemon.h

@@ -217,7 +217,7 @@ int dlt_daemon_local_connection_init(DltDaemon *daemon, DltDaemonLocal *daemon_l
 int dlt_daemon_local_ecu_version_init(DltDaemon *daemon, DltDaemonLocal *daemon_local, int verbose);
 
 void dlt_daemon_daemonize(int verbose);
-void dlt_daemon_exit_trigger();
+void dlt_daemon_exit_trigger(void);
 void dlt_daemon_signal_handler(int sig);
 #ifdef __QNX__
 void dlt_daemon_cleanup_timers();

src/daemon/dlt_daemon_client.c

@@ -817,7 +817,7 @@ int dlt_daemon_client_send_control_message_v2(int sock,
 
     msg->storageheadersizev2 = (uint32_t)(STORAGE_HEADER_V2_FIXED_SIZE + (daemon->ecuid2len));
     msg->baseheadersizev2 = BASE_HEADER_V2_FIXED_SIZE;
-    msg->baseheaderextrasizev2 = (int32_t)dlt_message_get_extraparameters_size_v2(DLT_CONTROL_MSG);
+    msg->baseheaderextrasizev2 = (uint32_t)dlt_message_get_extraparameters_size_v2(DLT_CONTROL_MSG);
     msg->extendedheadersizev2 = (uint32_t)((daemon->ecuid2len) + 1 + appidlen + 1 + ctxidlen + 1);
 
     msg->headersizev2 = (int32_t)(msg->storageheadersizev2 + msg->baseheadersizev2 +
@@ -5388,7 +5388,7 @@ void dlt_daemon_control_passive_node_connect_status_v2(int sock,
 
         con = &daemon_local->pGateway.connections[i];
 
-        resp->connection_status[i] = con->status;
+        resp->connection_status[i] = (uint8_t)con->status;
         //TBD: Review node_id[i * con->ecuid2len]
         memcpy(&resp->node_id[i * con->ecuid2len], con->ecuid2, con->ecuid2len);
     }
@@ -5471,7 +5471,7 @@ void dlt_daemon_control_passive_node_connect_status(int sock,
 
         con = &daemon_local->pGateway.connections[i];
 
-        resp->connection_status[i] = con->status;
+        resp->connection_status[i] = (uint8_t)con->status;
         memcpy(&resp->node_id[i * DLT_ID_SIZE], con->ecuid, DLT_ID_SIZE);
     }
 

src/examples/dlt-example-filetransfer.c

@@ -84,9 +84,10 @@ bool shutdownStatus = false;
  * The function will set the flag (shutdownStatus) to true after .2 sec
  * @return Null to stop thread
  */
-void *cancel_filetransfer()
+void *cancel_filetransfer(void* arg)
 {
     // wait 200msec once a filetransfer is started and then set the flag to true
+    (void)arg;
     struct timespec ts;
     ts.tv_sec = 0;
     ts.tv_nsec = 200000000; // 200 ms
@@ -99,8 +100,9 @@ void *cancel_filetransfer()
  * The function will start dlt filetransfer and will throw error if status of shutdownStatus is high
  * @return Null to stop thread
  */
-void *filetransfer()
+void *filetransfer(void* arg)
 {
+    (void)arg;
     int transferResult;
 
     transferResult = dlt_user_log_file_header(&fileContext, file);
@@ -125,7 +127,7 @@ void *filetransfer()
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/examples/dlt-example-multicast-clientmsg-view.c

@@ -96,7 +96,7 @@ int dlt_receive_message_callback_udp(DltMessage *message)
 {
     static char text[DLT_RECEIVE_TEXTBUFSIZE];
 
-    if ((message == NULL)) {
+    if (message == NULL) {
         printf("NULL message in dlt_receive_message_callback_udp\n");
         return -1;
     }
@@ -119,7 +119,7 @@ int dlt_receive_message_callback_udp(DltMessage *message)
 }
 
 
-int main()
+int main(void)
 {
     struct clientinfostruct clientinfo;
     struct ip_mreq mreq;

src/examples/dlt-example-user-common-api.c

@@ -66,7 +66,7 @@ DLT_DECLARE_CONTEXT(mycontext)
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/examples/dlt-example-user-func-v2.c

@@ -84,7 +84,7 @@ DltContextData mycontextdata;
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/examples/dlt-example-user-func.c

@@ -82,7 +82,7 @@ DltContextData mycontextdata;
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/examples/dlt-example-user-v2.c

@@ -88,7 +88,7 @@ DLT_DECLARE_CONTEXT(mycontext3)
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 
@@ -458,4 +458,4 @@ int dlt_user_injection_callback_with_specific_data(uint32_t service_id, void *da
 void dlt_user_log_level_changed_callback_v2(char *context_id, uint8_t log_level, uint8_t trace_status)
 {
     printf("Log level changed of context %s, LogLevel=%u, TraceState=%u\n", context_id, log_level, trace_status);
-}
+}

src/examples/dlt-example-user.c

@@ -86,7 +86,7 @@ DLT_DECLARE_CONTEXT(mycontext3)
 /**
  * Print usage information of tool.
  */
-void usage()
+void usage(void)
 {
     char version[255];
 

src/lib/dlt_env_ll.c

@@ -125,7 +125,8 @@ int dlt_env_helper_to_lower(char **const env, char *result, int const res_len)
 
 int dlt_env_extract_symbolic_ll(char **const env, int8_t *ll)
 {
-    char result[strlen("verbose") + 1];
+    char result[sizeof("verbose")];
+
 
     if (!env || !ll) {
         return -1;