feat(units): Add QUDT unit and quantity kind correspondances#900
feat(units): Add QUDT unit and quantity kind correspondances#900jdacoello wants to merge 2 commits into
Conversation
| quantity: length | ||
| allowed-datatypes: ['numeric'] | ||
| qudt-unit: http://qudt.org/vocab/unit/MilliM | ||
| qudt-quantity-kind: https://qudt.org/vocab/quantitykind/Length |
There was a problem hiding this comment.
I like it
From a tooling perspective it seems to be a bit superfluous to have both qudt-quantity-kind and quantity here. Maybe make quantityoptional if there is a qudt reference?
There was a problem hiding this comment.
@sschleemilch @jdacoello - adding the qudt references can be done without changing vss-tools. But what do you think of changing validation logic so that only one of quantity and qudt-quantity-kind are required. I.e. quantity needed only if qudt-quantity-kind is not defined. That way we could limit our file https://github.com/COVESA/vehicle_signal_specification/blob/master/spec/quantities.yaml to only include "custom" quantities.
There was a problem hiding this comment.
Fine for me. I can have a look.
Btw I would make it a bit more nested:
qudt:
unit: ...
kind: ...There was a problem hiding this comment.
Added indentation as suggested
|
MoM:
|
|
@jdacoello - could you update the markdown at https://github.com/COVESA/vehicle_signal_specification/blob/master/docs-gen/content/rule_set/data_entry/data_units.md#unit-file-syntax so that it mentions the two new fields as optional fields. Possibly also give an example. |
|
MoM:
|
Signed-off-by: JD Alvarez <8550265+jdacoello@users.noreply.github.com>
8d7bee3 to
c7f6515
Compare
Signed-off-by: JD Alvarez <8550265+jdacoello@users.noreply.github.com>
|
MoM:
|
Adds external reference to unit model QUDT as explained in #828
For example:
the unit kilometer
kmpoints to its correspondence https://qudt.org/vocab/unit/KiloM which has lots of extra metadata like translated labels, and conversion formulas.