Fix SD Route Initialization for Windows #856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sd_route_set_ flag is never set to true in the Windows build. As result, Service Discovery calls such as offer_service() will fail checks performed by routing_manager_impl::is_external_routing_ready(). One solution is to initialize the sd_route_set flag to true in Windows and QNX builds within routing_manager_impl::start_ip_routing().
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sd_route_set_ flag is never set to true in the Windows build. As result, Service Discovery calls such as offer_service() will fail checks performed by routing_manager_impl::is_external_routing_ready().
One solution is to initialize the sd_route_set flag to true in Windows and QNX builds within routing_manager_impl::start_ip_routing().