Remove explicit types on locks #907
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapped to a static_cast
Swapped to a static_cast
Switched to scoped_lock
Switched to scoped_lock
Switched to scoped_lock
…wing Switched to scoped_lock
…s shadowing Switched to scoped_lock
… Address shadowing Switched to scoped_lock
…uality: Address shadowing Switched to scoped_lock
…! Code Quality: Address shadowing Removed redundant converters
…! fixup! Code Quality: Address shadowing
…p! fixup! fixup! Code Quality: Address shadowing Removed explicit template from unique_ptr
…up! fixup! fixup! fixup! Code Quality: Address shadowing Removed explicit template from unique_ptr throughout codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Built on top of #840)
Removes the explicit templates on all
std::unique_lockconstructions