Skip to content

Even newer stat scripts - #457

Merged
erikbosch merged 1 commit into
COVESA:masterfrom
Giaccomole:even-newer-stat-scripts
Jul 29, 2025
Merged

Even newer stat scripts#457
erikbosch merged 1 commit into
COVESA:masterfrom
Giaccomole:even-newer-stat-scripts

Conversation

@Giaccomole

Copy link
Copy Markdown
Contributor

I was wondering whether we can just add --stats-* arguments to normal generators instead of introducing new commands and then still call the required other commands. Probably easier to do both in one go if requested. Then we would not even need to load the required file but have it already in RAM.

Now i carried the stat generation to stats_utils.py and created --stats-sankey --stats-radial and --stats-piechart to the CLI options.

@Giaccomole

Copy link
Copy Markdown
Contributor Author

DCO Summary
Commit sha: ddfe9dc, Author: Erik Jaegervall (Jägervall), Committer: Orhun Ucak; Can not find "Erik Jaegervall (Jägervall) 30996601+erikbosch@users.noreply.github.com", in ["Erik Jaegervall erik.jaegervall@se.bosch.com", "Erik Jaegervall erik.jaegervall@se.bosch.com"].

Comment thread src/vss_tools/exporters/csv.py Outdated
Comment thread src/vss_tools/exporters/csv.py
Comment thread src/vss_tools/exporters/csv.py Outdated
write_csv(types_rows, types_output)

# Generate statistics if requested
if stats_sankey or stats_piechart:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if stats_sankey or stats_piechart:
if stats_requested:

Comment thread src/vss_tools/exporters/csv.py Outdated
add_rows(types_rows, datatype_tree, with_instance_column)
write_csv(types_rows, types_output)

# Generate statistics if requested

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Generate statistics if requested

@erikbosch

Copy link
Copy Markdown
Collaborator

MoM:

  • Please review

@Giaccomole
Giaccomole force-pushed the even-newer-stat-scripts branch 6 times, most recently from 141d389 to e24e8e2 Compare July 22, 2025 09:07
Add comprehensive statistics export capabilities including:
- Pie chart statistics generation
- Sankey diagram data export
- Radial tree visualization support
- CLI options for statistics file outputs
- Integration with existing CSV export workflow

This enables advanced data visualization and analysis of VSS data structures.

Signed-off-by: Orhun Ucak <orhunucak@gmail.com>
@Giaccomole
Giaccomole force-pushed the even-newer-stat-scripts branch from e24e8e2 to 41bc45b Compare July 22, 2025 09:16
@erikbosch

Copy link
Copy Markdown
Collaborator

MoM:

  • Erik to check if any remaining work
  • If not ok to merge

@erikbosch

Copy link
Copy Markdown
Collaborator

Anything more that needs to be done before merge @Giaccomole ?

@Giaccomole

Copy link
Copy Markdown
Contributor Author

I think we are set.

@erikbosch
erikbosch merged commit e46e6f6 into COVESA:master Jul 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants