feat: +bump-my-version, moved deps to dev-deps, removed unneeded deps - #458
Conversation
Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
7d09995 to
67a07f0
Compare
| [project] | ||
| name = "vss-tools" | ||
| version = "6.0a0" | ||
| version = "6.0.0" |
There was a problem hiding this comment.
In the past we have used something like 6.0a0 on main to avoid that a local build will be presented as 6.0.0 on the CLI and build logs, i.e. preferably only the official 6.0.0 build shall present it self as 6.0.0 in build logs. The reason is that in the past we sometimes had problems that people had problem with vss, and it turned out they were using a developer-version or a version that was dirty in some other way.
There was a problem hiding this comment.
bump-my-version has also support for rc and or dev releases: https://github.com/callowayproject/bump-my-version?tab=readme-ov-file#add-support-for-pre-release-versions
There was a problem hiding this comment.
Added the dev suffixes and extended the README.
Workflow would then be:
mainhas-dev0suffix for the versionbump-my-version [minor|major|patch]on release and tag itbump-my-version pre_nafterwards onmainto develop for the next one
| Things to do for maintainers: | ||
|
|
||
| - Change `## Unreleased` in [CHANGELOG](CHANGELOG.md) to the desired version | ||
| - Bump the version using `bump-my-version` which is in the dev dependencies: |
There was a problem hiding this comment.
Will this bump .bumpversion.toml, pyroject.toml or both?
|
I am in general positive to the change but if/when merged we would need to look a bit on https://github.com/COVESA/vehicle_signal_specification/wiki/Release-Instructions-and-Checklist (which covers both vss and vss-tools as of today) and check what updates that are needed. The part that might need some update is how to update version identifier. As of today we typically do it at:
I assume that setup works also after this, but then maybe instructions needs to be somewhat modified, for instance by referring to the README. |
| [project] | ||
| name = "vss-tools" | ||
| version = "6.0a0" | ||
| version = "5.0.0-dev0" |
There was a problem hiding this comment.
For dev release the number should be next release? Or alternatively a post release? https://peps.python.org/pep-0440/#developmental-releases
|
MOM:
|
|
@sschleemilch - for your info, at the meeting yesterday we agreed to release vss 5.1 but not vss-tools 5.1. But @SebastianSchildt came with the good suggestion to release vss-tools 6.0 "soon" (but after vss 5.1 has been released). The rationale is that we have quite some changes on vss-tools that would be good to get out. That would also be a start on letting vss and vss-tools have separated release cycles. I.e. Vss 5.x will still specify in https://github.com/COVESA/vehicle_signal_specification/blob/master/scripts/install_vss_tools.sh that it wants a vss-tools 5.x version, but vss on master will (as today) use the latest version from master. With that said, if you like to you could be responsible for creating vss-tools 6.0 when it is time for it to test out the changes in this PR and update the wikis as needed. We may however wait for @jdacoello as he has some GraphQL changes in progress that possibly better should be included in the vss-tools 6.0 |
Not sure what all of that has to do with this PR though. So the idea of the Then you can decide when releasing what the next should be. |
I don't think so. It can evolve into 6.0.0 or 5.1.0. if we want to have additional milestones in the dev cycle it could also turn into 5.0.0-devN |
I guess it depends on how you define your paths, if we look at the example in https://github.com/callowayproject/bump-my-version?tab=readme-ov-file#visualize-the-new-versioning-path
... they show that you from 0.1.0 can go to various dev versions. From a dev version you can go to an rc version and from rc to a released version. They also show a path
|
|
Okay, seems like I did not understand how it works. So extending |
Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
f06694a to
0bb480c
Compare




About
Main idea is to add extending the CHANGELOG.md on pull-requests with sections defined accoring to keepachangelog.
When doing a release, a maintainer can exchange the
Unreleasedsection with a release version, bump the version, create a tag and uploading it withtwineCHANGELOG.mdReleasesection inREADME.mdwith instructions for maintainerstwineto dev dependencies