✨ added strict exceptions config file - #470
Conversation
|
I was wondering: should we have that really in every exporter? How about a |
You mean that you need to do things in two steps, like |
Yeah, when implementing I was wondering whether it is worth doing that for each exporter when the use case of CI could be just to run |
Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
b2d0349 to
76d342e
Compare
|
If it just contains the "optional check" I have no problems having it as a separate command. But on the other hand, there might be exporters that only can handle "strict" models, but I assume it is feasible for an exporter if neede to explicitly call the "strict check" (with default arguments) before continuing, in case it relies on that name patterns and similar limitations are followed. So no strong opinion. |
Okay, then maybe leave it like it is, even though it requires adding the same arg in all exporters |
erikbosch
left a comment
There was a problem hiding this comment.
LGTM, Anything more to do? I merged the other PR, do not know if the arg need to be added to that exporter as well.
Nothing more to do. If we have a new exporter I need to rebase though and add that arg... Will do |
About
Idea is to be able to enable
--strictand/or--abortse.g. in CI but allowing current existing violations.Added
--strict-exceptionsthat should point to a YAML file defining exceptions in the following way:Refactored available strict options into an enum and using it.