Conversation
superbock
force-pushed
the
python_37
branch
3 times, most recently
from
October 17, 2018 12:43
7a11de8 to
a926c73
Compare
superbock
force-pushed
the
python_37
branch
7 times, most recently
from
October 18, 2018 10:18
278e902 to
bb1491b
Compare
added 7 commits
October 18, 2018 12:49
3 tasks
superbock
pushed a commit
that referenced
this pull request
Nov 5, 2018
finally fixes the doctest issue (CI failures for Python 3.6+) mentioned in #374
SebastianPoell
pushed a commit
to SebastianPoell/madmom
that referenced
this pull request
Dec 6, 2018
finally fixes the doctest issue (CI failures for Python 3.6+) mentioned in CPJKU#374
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Enable Python 3.7 CI tests.
Furthermore, it fixes a couple of smaller issues:
py.testnp.maximumwarnings when working withNaNsRemaining TODOs before this pull request can be merged
However, enabling doctests for all modules lead to weird failures on Python 3.6 and 3.7. See https://travis-ci.org/CPJKU/madmom/jobs/442740662#L1167. However, this problem only persists for Python 3.6+ and is hard to nail down. Thus I disabled doctests for 3.6+.