Skip to content

add Python 3.7 support#374

Merged
superbock merged 10 commits into
masterfrom
python_37
Oct 18, 2018
Merged

add Python 3.7 support#374
superbock merged 10 commits into
masterfrom
python_37

Conversation

@superbock

@superbock superbock commented Aug 7, 2018

Copy link
Copy Markdown
Collaborator

Changes proposed in this pull request

Enable Python 3.7 CI tests.

Furthermore, it fixes a couple of smaller issues:

  • remove executable bit from some modules, thus doctests are not skipped any more
  • fix doctests for the modules previously skipped
  • enable testing of docstrings with py.test
  • fixed some np.maximum warnings when working with NaNs
  • use tuples for multidimensional indexing (to prevent future failures)
  • remove deprecated testing asserts

Remaining TODOs before this pull request can be merged

However, enabling doctests for all modules lead to weird failures on Python 3.6 and 3.7. See https://travis-ci.org/CPJKU/madmom/jobs/442740662#L1167. However, this problem only persists for Python 3.6+ and is hard to nail down. Thus I disabled doctests for 3.6+.

  • check if the failing doctests can be fixed; not sure what the actual problem is; cannot reproduce locally
  • see if Cannot install with Python 3.7 #373 still persists and what the reason for this failure might be, cannot reproduce locally

@superbock superbock changed the title Python 3.7 [WIP] Python 3.7 Aug 7, 2018
@superbock
superbock force-pushed the python_37 branch 3 times, most recently from 7a11de8 to a926c73 Compare October 17, 2018 12:43
@superbock
superbock force-pushed the python_37 branch 7 times, most recently from 278e902 to bb1491b Compare October 18, 2018 10:18

@fdlm fdlm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@superbock
superbock merged commit 11170ca into master Oct 18, 2018
@superbock superbock changed the title [WIP] Python 3.7 add Python 3.7 support Oct 18, 2018
@superbock
superbock deleted the python_37 branch October 19, 2018 08:05
superbock pushed a commit that referenced this pull request Nov 5, 2018
finally fixes the doctest issue (CI failures for Python 3.6+) mentioned in #374
SebastianPoell pushed a commit to SebastianPoell/madmom that referenced this pull request Dec 6, 2018
finally fixes the doctest issue (CI failures for Python 3.6+) mentioned in CPJKU#374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants