XCSP3 in tools #597
Draft
XCSP3 in tools #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempted to set time limit before solver object was created
# Conflicts: # cpmpy/solvers/exact.py # tests/test_solvers.py
|
todo: readme, add python an package requirements somewhere |
tias
reviewed
Jun 21, 2025
There was a problem hiding this comment.
the two solver changes should be pushed to master directly
excellent readme documentation
please drop "models/Fillomino-mini-5-0_c24.xml", now that we have the dataset loader we don't need an example file (within tools its pretty useless anyway)
asking for a pass/doc update over the globals
otherwise great... almost ready
tias
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also have an easy benchmarking script.