feat: PersistentHugr implements HugrView #2202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmondada
requested review from
zrho and
aborgna-q
and removed request for
a team and
zrho
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/persistenthugr #2202 +/- ##
=======================================================
+ Coverage 82.14% 82.24% +0.09%
=======================================================
Files 234 235 +1
Lines 41393 41984 +591
Branches 37492 38083 +591
=======================================================
+ Hits 34004 34528 +524
- Misses 5422 5479 +57
- Partials 1967 1977 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acl-cqc
reviewed
May 13, 2025
| @@ -93,6 +93,22 @@ impl<N: HugrNode> OutputBoundaryMap<N> { | |||
| .into_iter() | |||
| } | |||
|
|
|||
| /// The keys of the map. | |||
| /// | |||
| /// These will be either outgoing or incoming ports, depending on the | |||
There was a problem hiding this comment.
This makes me wonder - is this really an OutputBoundaryMap, rather than just a BoundaryMap?
There was a problem hiding this comment.
This was deleted by the SimpleReplacement simplification PR (#2208)
aborgna-q
reviewed
May 14, 2025
Comment on lines
+102
to
+107
| fn from_portgraph(&self, node: portgraph::NodeIndex) -> N { | ||
| let node = node.into(); | ||
| self.iter() | ||
| .find_map(|(&k, &v)| (v == node).then_some(k)) | ||
| .expect("Portgraph node not found in map") | ||
| } |
There was a problem hiding this comment.
Are we fine with doing a linear search here?
Do you think it's not worth it having a pair of maps instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2095