Backend frontend bridge #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkaru-2
reviewed
Apr 8, 2025
nkaru-2
reviewed
Apr 8, 2025
nkaru-2
reviewed
Apr 8, 2025
nkaru-2
reviewed
Apr 8, 2025
Collaborator
|
Look good, but check the things mentioned in the comments. |
ghanthk
reviewed
Apr 9, 2025
Collaborator
ghanthk
left a comment
ghanthk
left a comment
There was a problem hiding this comment.
I think everything looks alright overall, I agree with Nirvish that you should review the comments added though. Nice work! :))
nkaru-2
approved these changes
Apr 13, 2025
Collaborator
nkaru-2
left a comment
nkaru-2
left a comment
There was a problem hiding this comment.
I didn't know you were working on this, I was doing something similar. We can figure something out and implement the best of both ideas and make sure it works. But the everything else looks good.
ghanthk
approved these changes
Apr 15, 2025
Collaborator
ghanthk
left a comment
ghanthk
left a comment
There was a problem hiding this comment.
sorry about the late approve!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.