Final fixes #25
Open
Final fixes #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… again, returning to selection page, and checking the leaderboard.
Add image and gif files
Jordan-uiuc
approved these changes
May 11, 2025
Collaborator
There was a problem hiding this comment.
Everything looks great! Amazing job with the UI, really polished the game well. There a few conflicts with this branch and main but since the actual game is working perfectly I think we'll just accept all changes from this PR. The only issue with this PR is I think it's missing the updated test cases so it's failing about 10 tests. I think we can push this PR and then push just the test cases I had in the previous PR.
niyatig2
approved these changes
May 13, 2025
Collaborator
niyatig2
left a comment
niyatig2
left a comment
There was a problem hiding this comment.
Everything looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some fixes, added the image and gif files, added leaderboard, and changed the options at the end of game on both weather and trivia game.