Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Setup
Add NGINX Subrequest Authentication
* Warn user to end session first before navigate * Add lazy loading * Change component name * Install package for particles * Normalize website width and height * Add reusable big button component * Add reusable styled text component * Add background image for 404 text * Add not found page * Standardize full viewport responsively and load not found page * Add a reusable center container * Use center container * Add reusable particle background * Add peerprep logo * Add loading page * Remove navbar console log * Use loading page and add padding back * Install react helmet * Uninstall because package deprecated * Install react-helmet-async * Update header title and icon * Update header title * Add logo for navbar * Stretch the height if necessary * Increase favicon brightness * Use transparent navbar * Add signin prop * Change button text color responsively * Add signin prop * Use reusable button component * Use outlined variant for textfield * Update NavBar * Add NavBar logo as svg icon * Stretch height if overflow * Move navbar to another folder * Add reusable surface * Style app layout * Remove unused imports * Add reusable container * Fix container responsiveness issue * Increase column spacing * Style signin and signup page * Add reusable header and caption * Add title to form * remove unused component * Use material ui textfield component * Add label * Use outlined input * Add background * Add media for different difficulty level * Add dynamic rendering of difficuly card * Add reusable gradient background * Update title * Add media for signup page * Use card for difficulty selection * Remove unused components * Update backdrop action button layout * Update profile page * Remove unused imports * Use 100vh for vertical layout * Fix backdrop button responsive issue * Add padding * Delete old test * Style homepage layout * Rearrange import and delete unused * Scale svg down * Update profile page media * Handle password change only * Style matching page * Show header in sm viewport * Add credit * Discard code formatting * Make component more flexible * Change size * Update css * Add default question and some styling * Install react-draggable * Remove unused component * Style room page * Update CD for testing * Remove unused package json * Update media * Add tests * Fix image rendering issue * Remove redundant code for navbar * Add indentation * Fix card responsiveness issue * Correct NavBar name * Fix label cutoff issue * Fix label error color issue * Remove unnecessary question default category * Fix mobile hard to open chat issue * Fix primary action button text color * Scale docker image size down * Change button text to fulfil requirement Co-authored-by: Desmond To Cie Hong <[email protected]>
Add sample dotenv file for frontend
Add Readme
Fix README typo
Use GKE auth plugin
CD Update
* Correct syntax * Separate command * Update gcloud component * Install plugin in Ubuntu first * Install plugin with gcloud * Get GKE credentials * Use literals * Add install component * Remove gcp auth * Use different version of gke auth * Remove unused commands * Setup gcloud CLI with SA key * Correct version * Add docker auth back Co-authored-by: Desmond To Cie Hong <[email protected]>
* Add null check * Add start script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @DesmondTo @hsiaojietng @xyliew25 @pualixue