Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement sign-up and sign-in with username and password
…ect-ay2223s1-g60 into matching-service
…ect-ay2223s1-g60 into drake-user-frontend-service # Conflicts: # user-service/controller/user-controller.js # user-service/index.js # user-service/model/repository.js # user-service/model/user-model.js # user-service/model/user-orm.js # user-service/package-lock.json # user-service/package.json
- Implement RoomContext so we can access the information in the room easily - Everytime user click the button `Leave room`, all the information in the room (chats, code, language, question, both users' username) will be stored in DB
* Add history-svc test * Add CI * Add package-lock.json
* Modify response status * Implement user service testing * Modify the environment
* Fix room refresh problem for code * Fix refresh room problem * Implement save chats * Add circular progress when leaving room * Fix bug in remove waiting user * Notify no match found Co-authored-by: erinmayg <[email protected]> Co-authored-by: Florencia Martina <[email protected]>
* Add script to install dependencies * Update README.md
* Add .env.sample * Add README.md * Update README.md Co-authored-by: florenciamartina <[email protected]>
* Add sample env Co-authored-by: florenciamartina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @erinmayg @florenciamartina @jzwoo @drake25122000