Skip to content

organize code#121

Merged
Oliviaaaaa-Feng merged 4 commits intomainfrom
olivia/code-organize
Mar 19, 2025
Merged

organize code#121
Oliviaaaaa-Feng merged 4 commits intomainfrom
olivia/code-organize

Conversation

@Oliviaaaaa-Feng
Copy link
Copy Markdown
Contributor

organize code

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

.padding(.top, 10)

Spacer()
// TODO - add meal logging interface to add view // swiftlint:disable:this todo
Copy link
Copy Markdown
Contributor

@kkellybonilla kkellybonilla Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont delete, need this as personal reminder

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment on lines -42 to -45
// If it's a quick, short horizontal swipe, let it through
// as it's likely attempting to access the swipe actions
if isHorizontalDrag && !isQuickSwipe {
// Consume the gesture to prevent TabView swiping
Copy link
Copy Markdown
Contributor

@kkellybonilla kkellybonilla Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont delete, documentation, if anything you can put a todo for me to clean it up

@Oliviaaaaa-Feng Oliviaaaaa-Feng enabled auto-merge (squash) March 17, 2025 05:47
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.99%. Comparing base (43385a7) to head (3d8d4fa).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   34.99%   34.99%           
=======================================
  Files         104      104           
  Lines        4579     4579           
=======================================
  Hits         1602     1602           
  Misses       2977     2977           
Files with missing lines Coverage Δ
Stanford360/Protein/View/ProteinAddView.swift 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43385a7...3d8d4fa. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Oliviaaaaa-Feng Oliviaaaaa-Feng enabled auto-merge (squash) March 17, 2025 05:56
@Oliviaaaaa-Feng Oliviaaaaa-Feng enabled auto-merge (squash) March 18, 2025 05:26
@Oliviaaaaa-Feng Oliviaaaaa-Feng merged commit fca28ca into main Mar 19, 2025
6 checks passed
@Oliviaaaaa-Feng Oliviaaaaa-Feng deleted the olivia/code-organize branch March 19, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants