Skip to content

Add activity manager tests#125

Merged
Oliviaaaaa-Feng merged 2 commits intomainfrom
elsa-bismuth/test-activity
Mar 20, 2025
Merged

Add activity manager tests#125
Oliviaaaaa-Feng merged 2 commits intomainfrom
elsa-bismuth/test-activity

Conversation

@elsa-bismuth
Copy link
Copy Markdown
Contributor

@elsa-bismuth elsa-bismuth commented Mar 19, 2025

Add activity tests

♻️ Current situation & Problem

  • no tests for activity manager
  • cannot delete and edit an activity (was removed in PR 122)

⚙️ Release Notes

  • added tests for activity manager
  • removed swipe between tabs for activity and added swipe for edit and delete activity

Simulator Screenshot - iPhone 16 Pro Max - 2025-03-19 at 11 45 36
Simulator Screenshot - iPhone 16 Pro Max - 2025-03-19 at 11 45 49
Simulator Screenshot - iPhone 16 Pro Max - 2025-03-19 at 11 45 55
Simulator Screenshot - iPhone 16 Pro Max - 2025-03-19 at 11 46 00

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Tested activity manager

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (fca28ca) to head (6c8a960).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Stanford360/Activity/View/ActivityCardView.swift 0.00% 37 Missing ⚠️
Stanford360/Activity/View/ActivityAddView.swift 0.00% 13 Missing ⚠️
Stanford360/Activity/View/ActivityTabView.swift 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   34.99%   35.20%   +0.21%     
==========================================
  Files         104      104              
  Lines        4579     4620      +41     
==========================================
+ Hits         1602     1626      +24     
- Misses       2977     2994      +17     
Files with missing lines Coverage Δ
Stanford360/Activity/View/ActivityTabView.swift 0.00% <0.00%> (ø)
Stanford360/Activity/View/ActivityAddView.swift 0.00% <0.00%> (ø)
Stanford360/Activity/View/ActivityCardView.swift 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca28ca...6c8a960. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Oliviaaaaa-Feng Oliviaaaaa-Feng self-requested a review March 20, 2025 03:06
@Oliviaaaaa-Feng Oliviaaaaa-Feng merged commit 97a4cab into main Mar 20, 2025
7 of 8 checks passed
@Oliviaaaaa-Feng Oliviaaaaa-Feng deleted the elsa-bismuth/test-activity branch March 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants