fix: bug in plot_cluster_centers() by removing theme_void()
#222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void()` For some reason, `plot_cluster_centers()` would occassionaly not display the plot. Even on the same input template, sometimes the function would show the plot and sometimes it wouldn't. I can't find any reason why `ggplot2::theme_void()` would cause this problem, but changing it to `ggplot2::theme_bw()` fixes the bug.
stephaniereinders
changed the title
plot_cluster_centers() by removing `theme_void()plot_cluster_centers() by removing theme_void()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 25 25
Lines 3483 3484 +1
=======================================
+ Hits 3221 3222 +1
Misses 262 262 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
plot_cluster_centers()would occasionaly not display the plot. Even on the same input template, sometimes the function would show the plot and sometimes it wouldn't. I can't find any reason whyggplot2::theme_void()would cause this problem, but changing it toggplot2::theme_bw()fixes the bug.