43 sort cluster cols #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I uploaded the R scripts for handwriterRF to Claude and asked for a function map. The result is an html file that I added to the data-raw package. The file won't be included in the package.
…er_profiles()` `compare_documents()` now does the following: 1. handles NULL values 2. handles samples in different folders with the same name 3. creates project directory 4. runs basic checks 5. copies samples to project directory 6. estimates the writer profiles 7. compares the writer profiles with `compare_writer_profiles()` 8. cleans up project directory This reduces repetative code.
`get_cluster_cols()` is used by functions other than those in the distances.R script, so move it to utils.R
Some functions currently grab label columns by name, E.g. "docname", "writer", etc. But input data frames might have a variety of label columns, so `get_label_cols()` is an internal helper that will grab all columns that do not start with "cluster".
…ols()` and `get_label_cols()` Change `split_clusters_and_labels()` to call `get_cluster_cols()` and `get_label_cols()`. And update `get_single_dist()` and `absolute_dist()` to call `split_clusters_and_labels()`.
…numerically Fix train, validation, test, random_forest, and ref_scores so that cluster columns are sorted numerically. Fix `get_cluster_cols()` to sort cluster columns numerically. Create new test fixtures with updated data objects and functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data objects, functions, and test fixtures and tests are now all updated so that cluster columns are sorted numerically.