-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration files and Dockerfiles for every parts of the project #1
Conversation
f257e81
to
7fc2342
Compare
8dc94be
to
5e645c1
Compare
5e645c1
to
b83f951
Compare
b672e82
to
a91128a
Compare
2d90412
to
ba05852
Compare
ba05852
to
8500e02
Compare
…loads on cgroupsv2 machines
9e3dcf4
to
4ba12d9
Compare
4ba12d9
to
6b59c47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
At the end of the day, I implemented configuration file for the client (common for the 3 sub-programs) allowing :
and one for the server :
|
2f389f6
to
7d9daa3
Compare
7d9daa3
to
e859010
Compare
Last bits about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went though the code again. If you have time next week, moving the black / newline tools here would be good, but now I think the documentation is more important. Great work!
In addition to that, I implemented the usage of a configuration file for the server, allowing user to set vault's path, spire-server informations at runtime.