Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration files and Dockerfiles for every parts of the project #1

Merged
merged 18 commits into from
Mar 27, 2024

Conversation

telliere
Copy link
Collaborator

In addition to that, I implemented the usage of a configuration file for the server, allowing user to set vault's path, spire-server informations at runtime.

@telliere telliere force-pushed the feature/dockerfile_everywhere branch from f257e81 to 7fc2342 Compare March 21, 2024 11:24
@telliere telliere force-pushed the feature/dockerfile_everywhere branch 4 times, most recently from 8dc94be to 5e645c1 Compare March 21, 2024 14:20
@telliere telliere force-pushed the feature/dockerfile_everywhere branch from 5e645c1 to b83f951 Compare March 21, 2024 14:32
@telliere telliere force-pushed the feature/dockerfile_everywhere branch from b672e82 to a91128a Compare March 21, 2024 16:46
@telliere telliere force-pushed the feature/dockerfile_everywhere branch 5 times, most recently from 2d90412 to ba05852 Compare March 22, 2024 09:19
@telliere telliere force-pushed the feature/dockerfile_everywhere branch from ba05852 to 8500e02 Compare March 22, 2024 09:30
@telliere telliere requested a review from mmatthiesencsc March 25, 2024 08:41
@telliere telliere force-pushed the feature/dockerfile_everywhere branch from 9e3dcf4 to 4ba12d9 Compare March 25, 2024 09:06
@telliere telliere force-pushed the feature/dockerfile_everywhere branch from 4ba12d9 to 6b59c47 Compare March 25, 2024 09:20
Copy link
Collaborator

@mmatthiesencsc mmatthiesencsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@telliere telliere changed the title Adding dockerfiles for job_preparation and server Configuration files and Dockerfiles for every parts of the project Mar 25, 2024
@telliere
Copy link
Collaborator Author

At the end of the day, I implemented configuration file for the client (common for the 3 sub-programs) allowing :

  • Configuration of the vault address
  • Configuration of the hpcs server address
  • Configuration of the supercomputer (currently not fully used)
  • Configuration of the spire server (address, port and trust domain)

and one for the server :

  • Configuration of the vault address
  • Configuration of the spire server (address, port and trust domain)

@telliere telliere force-pushed the feature/dockerfile_everywhere branch 2 times, most recently from 2f389f6 to 7d9daa3 Compare March 26, 2024 09:18
@telliere telliere force-pushed the feature/dockerfile_everywhere branch from 7d9daa3 to e859010 Compare March 26, 2024 09:27
@telliere
Copy link
Collaborator Author

Last bits about age and gocryptfs static binaries are available, ready to merge

Copy link
Collaborator

@mmatthiesencsc mmatthiesencsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went though the code again. If you have time next week, moving the black / newline tools here would be good, but now I think the documentation is more important. Great work!

@mmatthiesencsc mmatthiesencsc merged commit 3fadcc5 into main Mar 27, 2024
5 checks passed
@mmatthiesencsc mmatthiesencsc deleted the feature/dockerfile_everywhere branch March 27, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants