Open
Conversation
This makes accidentally running the old playbooks less likely. When the playbooks are moved, the group vars are no longer in the same directory as they are, so they must be moved too. In addition to being in the same directory as the playbooks, they can also be in the same directory as the inventories, the latter approach being perhaps the neater. This is the first step in taking the [shared playbook wrapper into use](https://github.com/CSCfi/Kielipankki-ansible-common/blob/main/roles/playbook_wrappers/README.md).
The [normal procedure](https://github.com/CSCfi/Kielipankki-ansible-common/blob/main/roles/playbook_wrappers/README.md) is to place the group vars together with the inventory, but unfortunately in this repository, we have the inventories in subdirectories of their own, meaning that their inventory group vars need to be in different directories. This can be circumvented by keeping the group vars together with the playbooks. This means that the wrapper and the payload playbooks will have group vars of their own, but this is not a problem.
aajarven
force-pushed
the
KP-10944-wrapper-playbook
branch
from
c949020 to
d6785df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo has similar inventory directory structure as our proxy, so the group var location differs from the default in a way similar to https://github.com/CSCfi/Kielipankki-proxy/pull/96 here too.
NB: only the pouta / dev provisioning has been tested.