WIP KP-6954 Add nftables handling for non-vmware hosts#70
Open
WIP KP-6954 Add nftables handling for non-vmware hosts#70
Conversation
This is an attempt to parametrize in the inventories whether we are on a VMWare host, in case we try to stick to their funky processes, or if we're on some other (RH-based) host, in which case we use "normal" nftables rules literally. firewalld is another option, but it would be even more different from the VMWare stuff.
aajarven
reviewed
Apr 2, 2025
roles/firewall/tasks/main.yml
Outdated
Comment on lines
4
to
12
| - name: Include Pouta iptables configuration | ||
| when: not is_vmware | ||
| include_tasks: | ||
| file: pouta.yml | ||
|
|
||
| - name: Include VMWare iptables configuration | ||
| when: is_vmware | ||
| include_tasks: | ||
| file: vmware.yml |
Member
There was a problem hiding this comment.
Now that these have fully diverged, could we ditch the is_vmware variable and this "shared" task and instead remove the firewall task from korp-software.yml and do the pouta.yml and vmware.yml in corresponding pre/post-processing playbooks for pouta/production?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to parametrize in the inventories whether we are on a VMWare host, in case we try to stick to their funky processes, or if we're on some other (RH-based) host, in which case we use "normal" nftables rules literally.
firewalld is another option, but it would be even more different from the VMWare stuff.