Skip to content

Optimize GetProfileData2 method by removing unused database connection and redundant code #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarkikos merged 1 commit into from
Apr 29, 2026
+0 −6
Merged

Optimize GetProfileData2 method by removing unused database connection and redundant code #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions aspnetcore/src/api/Services/UserProfileService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,13 +1353,8 @@ public ProfileEditorSource GetProfileEditorSource(ProfileDataFromSql p)
/*
* Get profile data - refactored
*/

public async Task<ProfileEditorDataResponse> GetProfileData2(int userprofileId, LogUserIdentification logUserIdentification, bool forElasticsearch = false)
{
var connection = _ttvContext.Database.GetDbConnection();

List<FactFieldValue> ffvs = await _ttvContext.FactFieldValues.Where(ffv => ffv.DimUserProfileId == userprofileId).ToListAsync();

ProfileEditorDataResponse profileDataResponse = new()
{
personal = new ProfileEditorDataPersonal()
Expand Down Expand Up @@ -1387,7 +1382,6 @@ public async Task<ProfileEditorDataResponse> GetProfileData2(int userprofileId,
cooperation = await _cooperationChoicesService.GetCooperationChoices(userprofileId, forElasticsearch),
uniqueDataSources = await _uniqueDataSourcesService.GetUniqueDataSources(userprofileId, forElasticsearch)
};

return profileDataResponse;
}

Expand Down
Loading