Transition to NextJS frontend #131
Conversation
Mr-Oregano
left a comment
Mr-Oregano
left a comment
There was a problem hiding this comment.
Still haven't tested the branch yet, just left some minor comments for this for now.
| <!-- <a class="logo-text" href="http://localhost:3000/">Computer Science Learning Center</a> --> | ||
|
|
||
| <!-- Prod --> | ||
| <a class="logo-text" href="https://uno-cslc-ticket-portal.vercel.app/">Computer Science Learning Center</a> |
There was a problem hiding this comment.
Can this be a relative path?
There was a problem hiding this comment.
It looks like the link should be for the index page. I didn't know if this was for testing or not. Could it just be /?
There was a problem hiding this comment.
no it can't be / because I ported the home page.
The home page lives on vercel. It's completely detached from the flask service right now which allows both to co-exist.
Since we still have other pages in flask that have not yet been ported, I can't link back to / because that'd be the flask app.
Locally the NextJS frontend runs on port 3000
There was a problem hiding this comment.
Can you merge this with the main .gitignore and delete this one?
There was a problem hiding this comment.
The goal is to have different services (front and backend)
Do you really want to make this a monolithic repository?
I figured it could be split up into a separate repo and included as a submodule if you really need the front end in here.
That's something we can do once the migration is complete
There was a problem hiding this comment.
Sure we could try to do that
2 participants
I'm thinking it would be best to use a hardened framework for the frontend portion of this application, specifically NextJS.
End goal is to fully migrate your frontend to next js and make python purely API focused.
This PR includes a ported home page (
/) and interoperability between the flask and next js application.My deployment strategy would be to simply use vercel to host next js, and keep whatever you guys had for the rest of the app.
I setup a working example here
Please note that, since I don't have access to your staging servers, I am running the python portion locally and exposing it through ngrok.
Should something break when you try it, it may have just been killed by me or my computer.