-
Notifications
You must be signed in to change notification settings - Fork 61
io compartments to compression libraries #2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brooksdavis
wants to merge
3
commits into
dev
Choose a base branch
from
zlib-compartments
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
approved these changes
Feb 21, 2025
7439927
to
9ddd36d
Compare
With this change:
liblzma appears to avoid IO entirely. |
bsdjhb
reviewed
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will pull this locally and do some testing as I want to see what the latest c18n toolchain logs for this.
zlib has two major parts. The core deflate compression works entirely in memory. There is also the gzlib portion which provides an analog to POSIX IO interfaces and uses IO underneath.
libbz2 has three parts (two of which are io). There is a core of in-memory compression/decompression, a stdio based file IO interface, and a partial emulation of the gzlib interface.
This isn't a conventional IO interface, but rather some debugging code that is always compiled it. Compartmentalize it anyway to limit the blast radius of bugs elsewhere in the library.
9ddd36d
to
e7e54fe
Compare
FYI, no surprises in the --verbose-c18n logs from the latest version of lld. I think this is fine to merge still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zlib has two major parts. The core deflate compression works entierly in memory. There is also the gzlib portion which provides an analog to POSIX IO interfaces and uses IO underneath.