c18n: add partial SYSERRCAUSE to kern.proc.c18n.compartments #2388
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report error cause for things that might cause EFAULT
bsdjhb
reviewed
Apr 3, 2025
| @@ -2683,14 +2689,21 @@ sysctl_kern_proc_c18n_compartments(SYSCTL_HANDLER_ARGS) | |||
| */ | |||
| error = proc_read_string_properly(curthread, p, | |||
There was a problem hiding this comment.
Robert's failure is actually EPROT from his ktrace, and I bet it is inside of here, perhaps where we use cheri_can_access.
There was a problem hiding this comment.
Actually, there is an EPROT a few lines earlier here due to a cheri_can_access you'd want to log as well.
There was a problem hiding this comment.
Hmm, I wonder why we do a separate cheri_can_access on each entry instead of just doing a single check for the entire array of info.comparts up front.
There was a problem hiding this comment.
Yes, good point. We can definitely do that.
dpgao
approved these changes
Apr 7, 2025
|
I actually have lifted it out in another branch already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report error cause for things that might cause EFAULT
cc @rwatson