Declare ptraddr_t in (sys/)stddef.h and not in stdint.h #2495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtc27
reviewed
Dec 8, 2025
Comment on lines
17
to
18
| #include <stdio.h> | ||
| #include <stddef.h> |
Member
There was a problem hiding this comment.
Suggested change
| #include <stdio.h> | |
| #include <stddef.h> | |
| #include <stddef.h> | |
| #include <stdio.h> |
But please don't just patch the subrepo
Member
Author
There was a problem hiding this comment.
I'll make this a separate do-no-merge commit and pull it before merging.
jrtc27
reviewed
Dec 8, 2025
jrtc27
reviewed
Dec 8, 2025
| typedef size_t __ptraddr_t; | ||
| #endif | ||
| typedef __ptraddr_t ptraddr_t; | ||
| typedef size_t ptraddr_t; |
Member
There was a problem hiding this comment.
If our sys/types.h doesn't define it then OpenZFS's shouldn't really either...
jrtc27
reviewed
Dec 8, 2025
jrtc27
reviewed
Dec 8, 2025
jrtc27
reviewed
Dec 8, 2025
brooksdavis
force-pushed
the
ptraddr_t-cleanup
branch
2 times, most recently
from
66b8743 to
f5b66e0
Compare
It has been deprecated for some time and replaced by ptraddr_t.
brooksdavis
force-pushed
the
ptraddr_t-cleanup
branch
from
f5b66e0 to
cff346a
Compare
This function is only used in freebsd64_signal.c so move it there. This avoids the need for ptraddr_t to be declared in sys/signal.h.
We don't have a defintion guard for __ptraddr_t and indentical redefinitions aren't allowed in C99 to just define ptraddr_t as size_t if needed. This will be fine on any architecture OpenZFS supports.
Stick to stddef.h like ptrdiff_t.
brooksdavis
force-pushed
the
ptraddr_t-cleanup
branch
from
cff346a to
a24ec20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pick one place for ptraddr_t and I've upstreamed it to stddef.h matching the various CHERI LLVM ports. I've removed the definition from stdint.h and removed the long unused vaddr_t while here.